3

make link_llvm_intrinsics and platform_intrinsics features internal by RalfJung...

 11 months ago
source link: https://github.com/rust-lang/rust/pull/116093
Go to the source link to view the article. You can view the picture content, updated content and better typesetting reading experience. If the link is broken, please click the button below to view the snapshot at that time.
neoserver,ios ssh client

Conversation

Member

These are both a lot like feature(intrinsics), just slightly different syntax, so IMO it should be treated the same (also in terms of: if you get ICEs with this feature, that's on you -- we are not doing "nice" type-checking for intrinsics).

Collaborator

r? @oli-obk

(rustbot has picked a reviewer for you, use r? to override)

rustbot

added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue.

labels

Sep 23, 2023

RalfJung

changed the title make link_llvm_intrinsics feature internal

make link_llvm_intrinsics and platform_intrinsics features internal

Sep 23, 2023

Member

For LLVM intrinsics you wouldn't "just" ICE, you would likely segfault the compiler on incorrect usage.

Contributor

@bors r+ rollup

Contributor

📌 Commit ab83073 has been approved by oli-obk

It is now in the queue for this repository.

bors

added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion.

and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties.

labels

Sep 27, 2023

Contributor

⌛ Testing commit ab83073 with merge 92009f2...

Contributor

☀️ Test successful - checks-actions
Approved by: oli-obk
Pushing 92009f2 to master...

bors

added the merged-by-bors This PR was explicitly merged by bors label

Sep 27, 2023

bors

merged commit 92009f2 into

rust-lang:master

Sep 27, 2023

12 checks passed

Collaborator

Finished benchmarking commit (92009f2): comparison URL.

Overall result: ❌ regressions - no action needed

@rustbot label: -perf-regression

Instruction count

This is a highly reliable metric that was used to determine the overall result at the top of this comment.

mean range count
Regressions ❌
(primary)		 - - 0
Regressions ❌
(secondary)		 0.3% [0.3%, 0.3%] 3
Improvements ✅
(primary)		 - - 0
Improvements ✅
(secondary)		 - - 0
All ❌✅ (primary) - - 0

Max RSS (memory usage)

Results

Cycles

This benchmark run did not return any relevant results for this metric.

Binary size

This benchmark run did not return any relevant results for this metric.

Bootstrap: 632.103s -> 632.158s (0.01%)
Artifact size: 317.29 MiB -> 317.25 MiB (-0.01%)

RalfJung

deleted the link_llvm_intrinsics branch

September 30, 2023 20:27

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

oli-obk

Labels
merged-by-bors This PR was explicitly merged by bors S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue.
Projects

None yet

Milestone

1.74.0

Development

Successfully merging this pull request may close these issues.

None yet

6 participants

report

Recommend

About Joyk


Aggregate valuable and interesting links.
Joyk means Joy of geeK