Reveal opaque types before drop elaboration by oli-obk · Pull Request #115759 ·...
source link: https://github.com/rust-lang/rust/pull/115759
Go to the source link to view the article. You can view the picture content, updated content and better typesetting reading experience. If the link is broken, please click the button below to view the snapshot at that time.
Conversation
Contributor
fixes #113594
r? @cjgillot
cc @JakobDegen
This pass was introduced in #110714
I moved it before drop elaboration (which only cares about the hidden types of things, not the opaque TAIT or RPIT type) and set it to run unconditionally (instead of depending on the optimization level and whether the inliner is active)
added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue.
labels
Collaborator
|
Some changes occurred to MIR optimizations cc @rust-lang/wg-mir-opt |
Contributor
Author
This comment has been minimized.
added the S-waiting-on-perf Status: Waiting on a perf run to be completed. label
This comment has been minimized.
Contributor
|
☀️ Try build successful - checks-actions |
This comment has been minimized.
|
This doesn't fix when there's an |
fn is_enabled(&self, sess: &rustc_session::Session) -> bool { |
||
sess.mir_opt_level() >= 3 || super::inline::Inline.is_enabled(sess) |
||
} |
||
fn run_pass(&self, tcx: TyCtxt<'tcx>, body: &mut Body<'tcx>) { |
||
// Do not apply this transformation to generators. |
||
if body.generator.is_some() { |
We could remove this?
Contributor
Author
yea, that fixes the issue and has no fallout.
#115763 does this on its own
This comment has been minimized.
Collaborator
|
Finished benchmarking commit (e3f388f): comparison URL. Overall result: ❌✅ regressions and improvements - ACTION NEEDEDBenchmarking this pull request likely means that it is perf-sensitive, so we're automatically marking it as not fit for rolling up. While you can manually mark this PR as fit for rollup, we strongly recommend not doing so since this PR may lead to changes in compiler perf. Next Steps: If you can justify the regressions found in this try perf run, please indicate this with @bors rollup=never Instruction countThis is a highly reliable metric that was used to determine the overall result at the top of this comment.
Max RSS (memory usage)Results CyclesThis benchmark run did not return any relevant results for this metric. Binary sizeResults Bootstrap: 629.05s -> 630.934s (0.30%) |
added perf-regression Performance regressions
and removed S-waiting-on-perf Status: Waiting on a perf run to be completed.
labels
Contributor
|
r=me with ci passing. |
added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author.
and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties.
labels
Collaborator
|
Some changes occurred to the CTFE / Miri engine cc @rust-lang/miri Some changes occurred in compiler/rustc_codegen_cranelift cc @bjorn3 |
Contributor
|
that's nice 👍 @bors r+ |
added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion.
and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author.
labels
Contributor
|
☀️ Test successful - checks-actions |
Collaborator
|
Finished benchmarking commit (c545019): comparison URL. Overall result: ❌✅ regressions and improvements - no action needed@rustbot label: -perf-regression Instruction countThis is a highly reliable metric that was used to determine the overall result at the top of this comment.
Max RSS (memory usage)Results CyclesThis benchmark run did not return any relevant results for this metric. Binary sizeResults Bootstrap: 631.779s -> 634.388s (0.41%) |
bors-ferrocene bot
added a commit to ferrocene/ferrocene that referenced this pull request
bors-ferrocene bot
added a commit to ferrocene/ferrocene that referenced this pull request
bors-ferrocene bot
added a commit to ferrocene/ferrocene that referenced this pull request
bors-ferrocene bot
added a commit to ferrocene/ferrocene that referenced this pull request
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
None yet
Successfully merging this pull request may close these issues.
Recommend
About Joyk
Aggregate valuable and interesting links.
Joyk means Joy of geeK