Correct codegen of `ConstValue::Indirect` scalar and scalar pair by cjgillot · P...
source link: https://github.com/rust-lang/rust/pull/116102
Go to the source link to view the article. You can view the picture content, updated content and better typesetting reading experience. If the link is broken, please click the button below to view the snapshot at that time.
Correct codegen of ConstValue::Indirect scalar and scalar pair
#116102
Conversation
Contributor
This concerns 3 tricky cases with ConstValue::Indirect:
- if we want a non-pointer scalar;
- if we have non-zero offset;
- if offset points to uninit memory => generate
poisoninstead of an ICE. This case could happen in unreachable code, trying to extract a field from the wrong variant.
Those cases are not currently emitted by the compiler, but are exercised by #116012.
Collaborator
|
r? @oli-obk (rustbot has picked a reviewer for you, use r? to override) |
added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue.
labels
Contributor
|
@bors r+ rollup |
added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion.
and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties.
labels
Member
|
@bors rollup=iffy |
Contributor
|
☀️ Test successful - checks-actions |
Collaborator
|
Finished benchmarking commit (5899a80): comparison URL. Overall result: no relevant changes - no action needed@rustbot label: -perf-regression Instruction countThis benchmark run did not return any relevant results for this metric. Max RSS (memory usage)Results CyclesThis benchmark run did not return any relevant results for this metric. Binary sizeThis benchmark run did not return any relevant results for this metric. Bootstrap: 632.697s -> 633.132s (0.07%) |
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
No reviews
None yet
Successfully merging this pull request may close these issues.
None yet
Recommend
About Joyk
Aggregate valuable and interesting links.
Joyk means Joy of geeK