Promote loongarch64-unknown-none* to Tier 2 by heiher · Pull Request #115368 · r...
source link: https://github.com/rust-lang/rust/pull/115368
Go to the source link to view the article. You can view the picture content, updated content and better typesetting reading experience. If the link is broken, please click the button below to view the snapshot at that time.
Promote loongarch64-unknown-none* to Tier 2 #115368
Conversation
Collaborator
r? @JohnTitor (rustbot has picked a reviewer for you, use r? to override) |
added A-testsuite Area: The testsuite used to check the correctness of rustc S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-infra Relevant to the infrastructure team, which will review and decide on the PR/issue.
labels
Contributor
Author
Could you please trigger a try build? |
@bors try |
Contributor
⌛ Trying commit afb9e961c4d0852daca63b67c72ca13283a2ae1a with merge 33a6d20727ff80d19d8e4fb41f083039d4555a55... |
Contributor
☀️ Try build successful - checks-actions |
Member
r? compiler |
Contributor
r? @wesleywiser as the MCP seconder |
Contributor
Author
@wesleywiser gentle ping |
Contributor
Author
r? @Mark-Simulacrum "Promotion" may have more to do with infrastructure. I see that only a small amount of library code needs to be compiled for the bare metal target, which puts very little pressure on the build. The 1.74 version will be branched off from the master on Sep 29th. Could you please review this before then? 😃 |
The compiler team has approved the MCP for promotion to Tier 2 and these changes look correct to me but the Infra team needs to sign off on the addition to CI.
Member
CI overhead should be negligible as this doesn't add a new standalone job. @bors r+ |
added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion.
and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties.
labels
Contributor
☀️ Test successful - checks-actions |
Contributor
Author
@rustbot label: +relnotes |
added the relnotes Marks issues that should be documented in the release notes of the next release. label
Collaborator
Finished benchmarking commit (b8b376a): comparison URL. Overall result: no relevant changes - no action needed@rustbot label: -perf-regression Instruction countThis benchmark run did not return any relevant results for this metric. Max RSS (memory usage)Results CyclesResults Binary sizeThis benchmark run did not return any relevant results for this metric. Bootstrap: 632.26s -> 631.081s (-0.19%) |
Contributor
Looks like this PR narrowly missed the beta promotion? Do we still want to stuff it into beta? |
Member
It did not miss -- it merged before the version bump in #116302, so it was still auto-added to milestone 1.74.0. But generally, no, we would not do a beta backport for a feature like this, only for high-impact bugs. The point of having frequent releases is that it should not be a big deal to wait for the next one. |
Contributor
Thanks for the explanation! I checked the beta branch previously but didn't see this commit, hence the question. (I'd agree with waiting for the next release if the change actually missed 1.74.0, though.) |
bors-ferrocene bot
added a commit to ferrocene/ferrocene that referenced this pull request
bors-ferrocene bot
added a commit to ferrocene/ferrocene that referenced this pull request
bors-ferrocene bot
added a commit to ferrocene/ferrocene that referenced this pull request
bors-ferrocene bot
added a commit to ferrocene/ferrocene that referenced this pull request
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
None yet
Successfully merging this pull request may close these issues.
None yet
Recommend
About Joyk
Aggregate valuable and interesting links.
Joyk means Joy of geeK