7

Remove `constness` from `ParamEnv` by fee1-dead · Pull Request #114134 · rust-la...

 1 year ago
source link: https://github.com/rust-lang/rust/pull/114134
Go to the source link to view the article. You can view the picture content, updated content and better typesetting reading experience. If the link is broken, please click the button below to view the snapshot at that time.
neoserver,ios ssh client

Conversation

Member

This should be replaced by keyword generics/effects. cc #110395

r? @oli-obk

rustbot

added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. WG-trait-system-refactor The Rustc Trait System Refactor Initiative

labels

Jul 27, 2023

fee1-dead

marked this pull request as ready for review

July 27, 2023 15:53

Collaborator

Some changes occurred in src/tools/clippy

cc @rust-lang/clippy

Some changes occurred to the CTFE / Miri engine

cc @rust-lang/miri

Some changes occurred to the core trait solver

cc @rust-lang/initiative-trait-system-refactor

Some changes occurred to the CTFE / Miri engine

cc @rust-lang/miri

This comment has been minimized.

Contributor

@bors r+

fee1-dead reacted with heart emoji

Contributor

pushpin Commit b0fa220 has been approved by oli-obk

It is now in the queue for this repository.

bors

added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion.

and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties.

labels

Jul 28, 2023

Contributor

⌛ Testing commit b0fa220 with merge aafd75a...

Contributor

sunny Test successful - checks-actions
Approved by: oli-obk
Pushing aafd75a to master...

Collaborator

Finished benchmarking commit (aafd75a): comparison URL.

Overall result: ✅ improvements - no action needed

@rustbot label: -perf-regression

Instruction count

This is a highly reliable metric that was used to determine the overall result at the top of this comment.

mean range count
Regressions x
(primary)
- - 0
Regressions x
(secondary)
- - 0
Improvements white_check_mark
(primary)
-0.4% [-0.6%, -0.3%] 23
Improvements white_check_mark
(secondary)
-0.5% [-0.7%, -0.3%] 16
All ❌✅ (primary) -0.4% [-0.6%, -0.3%] 23

Max RSS (memory usage)

Results

Cycles

Results

Binary size

This benchmark run did not return any relevant results for this metric.

Bootstrap: 652.048s -> 651.183s (-0.13%)

fee1-dead

deleted the rm-constness-from-param-env branch

July 29, 2023 08:11

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

blyxyas

blyxyas left review comments
Assignees

oli-obk

Labels
merged-by-bors This PR was explicitly merged by bors S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue.
Projects

None yet

Milestone

1.73.0

Development

Successfully merging this pull request may close these issues.

None yet

8 participants

About Joyk


Aggregate valuable and interesting links.
Joyk means Joy of geeK