3

fix(resolve): skip panic when resolution is dummy by bvanjoi · Pull Request #113...

 1 year ago
source link: https://github.com/rust-lang/rust/pull/113980
Go to the source link to view the article. You can view the picture content, updated content and better typesetting reading experience. If the link is broken, please click the button below to view the snapshot at that time.
neoserver,ios ssh client

fix(resolve): skip panic when resolution is dummy #113980

Conversation

Contributor

Fixes #113953

Skip the panic when the binding refers to a dummy node during the finalization.

r? @petrochenkov

SoonIter reacted with thumbs up emoji

rustbot

added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue.

labels

Jul 23, 2023

petrochenkov

added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author.

and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties.

labels

Jul 24, 2023

Contributor

@bors r+ rollup

Contributor

pushpin Commit 4cc3834 has been approved by petrochenkov

It is now in the queue for this repository.

bors

added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion.

and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author.

labels

Jul 24, 2023

Contributor

⌛ Testing commit 4cc3834 with merge 5b1dc9d...

Contributor

sunny Test successful - checks-actions
Approved by: petrochenkov
Pushing 5b1dc9d to master...

bors

added the merged-by-bors This PR was explicitly merged by bors label

Jul 25, 2023

bors

merged commit 5b1dc9d into

rust-lang:master

Jul 25, 2023

12 checks passed

Collaborator

Finished benchmarking commit (5b1dc9d): comparison URL.

Overall result: x regressions - no action needed

@rustbot label: -perf-regression

Instruction count

This is a highly reliable metric that was used to determine the overall result at the top of this comment.

mean range count
Regressions x
(primary)
- - 0
Regressions x
(secondary)
0.5% [0.3%, 1.0%] 3
Improvements white_check_mark
(primary)
- - 0
Improvements ✅
(secondary)
- - 0
All xwhite_check_mark (primary) - - 0

Max RSS (memory usage)

Results

Cycles

This benchmark run did not return any relevant results for this metric.

Binary size

This benchmark run did not return any relevant results for this metric.

Bootstrap: 651.449s -> 650.538s (-0.14%)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

estebank

estebank left review comments

petrochenkov

petrochenkov left review comments
Labels
merged-by-bors This PR was explicitly merged by bors S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue.
Projects

None yet

Milestone

1.73.0

Development

Successfully merging this pull request may close these issues.

ICE: inconsistent resolution for an import

6 participants

About Joyk


Aggregate valuable and interesting links.
Joyk means Joy of geeK