7

Don't attempt to compute layout of type referencing error by compiler-errors · P...

 1 year ago
source link: https://github.com/rust-lang/rust/pull/113773
Go to the source link to view the article. You can view the picture content, updated content and better typesetting reading experience. If the link is broken, please click the button below to view the snapshot at that time.
neoserver,ios ssh client

Conversation

Leads to more ICEs and strange diagnostics than are worth it.

Fixes #113760

Collaborator

r? @TaKO8Ki

(rustbot has picked a reviewer for you, use r? to override)

rustbot

added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue.

labels

Jul 16, 2023

This comment has been minimized.

Contributor

umbrella The latest upstream changes (presumably #113166) made this pull request unmergeable. Please resolve the merge conflicts.

Contributor

@bors r+ rollup

Contributor

📌 Commit 131aeea has been approved by cjgillot

It is now in the queue for this repository.

bors

added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion.

and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties.

labels

Jul 22, 2023

This comment has been minimized.

Member

Author

@bors r-

lemme fix that test, fallout from failing layout computation i guess thinking

bors

added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author.

and removed S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion.

labels

Jul 22, 2023

Member

Author

r? @cjgillot

could use a tiny look at that last commit, it's there to suppress the CTFE errors from the more aggressive layout_of bailing.

compiler-errors

added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties.

and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author.

labels

Jul 27, 2023

Contributor

@bors r+

Contributor

📌 Commit d45eb41 has been approved by cjgillot

It is now in the queue for this repository.

bors

added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion.

and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties.

labels

Jul 28, 2023

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

cjgillot

Labels
S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue.
Projects

None yet

Milestone

1.73.0

Development

Successfully merging this pull request may close these issues.

ICE: field.0.is_sized()

6 participants

About Joyk


Aggregate valuable and interesting links.
Joyk means Joy of geeK