6

fix(resolve): report unresolved imports firstly by bvanjoi · Pull Request #11392...

 1 year ago
source link: https://github.com/rust-lang/rust/pull/113920
Go to the source link to view the article. You can view the picture content, updated content and better typesetting reading experience. If the link is broken, please click the button below to view the snapshot at that time.
neoserver,ios ssh client

fix(resolve): report unresolved imports firstly #113920

Conversation

Contributor

rustbot

added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue.

labels

Jul 21, 2023

petrochenkov

added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author.

and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties.

labels

Jul 25, 2023

Contributor

Author

I have adopted a more intuitive approach: initially, an unresolved_import is reported, followed by indeterminate_imports if no errors are present.

@rustbot ready

rustbot

added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties.

and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author.

labels

Jul 28, 2023

bvanjoi

changed the title resolve: only report import without any resolution for unresolved error

fix(resolve): report unresolved imports firstly

Jul 28, 2023

Contributor

This is certainly better.
@bors r+

Contributor

pushpin Commit 1b18e2a has been approved by petrochenkov

It is now in the queue for this repository.

bors

added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion.

and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties.

labels

Jul 31, 2023

bors

merged commit 2de51cc into

rust-lang:master

Jul 31, 2023

11 checks passed

rust-timer

added a commit to rust-lang-ci/rust that referenced this pull request

Jul 31, 2023

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

petrochenkov

petrochenkov left review comments
Labels
S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue.
Projects

None yet

Milestone

1.73.0

Development

Successfully merging this pull request may close these issues.

Rustc shows unnecessary big error when glob reexport failed

4 participants

About Joyk


Aggregate valuable and interesting links.
Joyk means Joy of geeK