Disable Spectre JIT mitigations in Fission content processes
source link: https://bugzilla.mozilla.org/show_bug.cgi?id=1837602
Go to the source link to view the article. You can view the picture content, updated content and better typesetting reading experience. If the link is broken, please click the button below to view the snapshot at that time.
Disable Spectre JIT mitigations in Fission content processes
Categories
(Core :: JavaScript Engine, task, P1)
Tracking
(bug RESOLVED as FIXED)
116 Branch
| Tracking | Status | |
|---|---|---|
| firefox116 | --- | fixed |
People
(Reporter: jandem, Assigned: jandem)
References
(Blocks 1 open bug)
Details
(Keywords: perf-alert)
Filing this bug to track flipping the javascript.options.spectre.disable_for_isolated_content pref when we're ready.
I think we should start first Nightly only, that is where ORB has been enabled for some time now.
(In reply to Olli Pettay [:smaug][[email protected]] from comment #1)
I think we should start first Nightly only, that is where ORB has been enabled for some time now.
Agreed. Enabling it Nightly-only soon is what we were thinking and then later we can let it ride the trains.
(In reply to Tetsuharu OHZEKI [:tetsuharu] (UTC+9) from comment #7)
We need still enable this mitigation for Android even if Nightly build?
Mitigations are still enabled on Android because we only disable them for Fission isolated processes. See here.
(In reply to Jan de Mooij [:jandem] from comment #8)
(In reply to Tetsuharu OHZEKI [:tetsuharu] (UTC+9) from comment #7)
We need still enable this mitigation for Android even if Nightly build?
Mitigations are still enabled on Android because we only disable them for Fission isolated processes. See here.
Thank you!
== Change summary for alert #38896 (as of Tue, 27 Jun 2023 23:24:04 GMT) ==
Improvements:
| Ratio | Test | Platform | Options | Absolute values (old vs new) |
|---|---|---|---|---|
| 37% | perf_reftest_singletons getElementById-1.html | windows10-64-shippable-qr | e10s fission stylo webrender | 47.42 -> 29.79 |
| 11% | kraken | linux1804-64-shippable-qr | e10s fission stylo webrender | 1,370.08 -> 1,218.18 |
| 9% | kraken | windows10-64-shippable-qr | e10s fission stylo webrender | 1,140.08 -> 1,040.41 |
| 8% | dromaeo_css | windows10-64-shippable-qr | e10s fission stylo webrender | 19,346.58 -> 20,888.91 |
| 3% | pdfpaint | linux1804-64-shippable-qr | e10s fission stylo webrender-sw | 753.63 -> 730.87 |
For up to date results, see: https://treeherder.mozilla.org/perfherder/alerts?id=38896(In reply to Pulsebot from comment #5)
Pushed by [email protected]:
https://hg.mozilla.org/integration/autoland/rev/47d6f0032249
Disable JS Spectre mitigations for Fission content processes in Nightly.
r=iain
Recommend
About Joyk
Aggregate valuable and interesting links.
Joyk means Joy of geeK