One-off search engines removed via the tick are reactivated when changing browse...
source link: https://bugzilla.mozilla.org/show_bug.cgi?id=1689986
Go to the source link to view the article. You can view the picture content, updated content and better typesetting reading experience. If the link is broken, please click the button below to view the snapshot at that time.
One-off search engines removed via the tick are reactivated when changing browser-language
Categories
(Firefox :: Search, defect, P3)
Tracking
(bug has been fixed and VERIFIED)
116 Branch
| Tracking | Status | |
|---|---|---|
| firefox116 | --- | verified |
People
(Reporter: boontje, Assigned: klubana)
Details
(Keywords: papercut, Whiteboard: [snt-scrubbed][search-papercut])
 |
Reporter | |
Description•3 years ago
|
||
User Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:85.0) Gecko/20100101 Firefox/85.0
Steps to reproduce:
- Disable all search-engines (remove the blue ticks in this example screenshot https://i.postimg.cc/sgjXNJT7/search-Engines-Bug.jpg
- Set browser-language from german to english or english to german
- click "apply and restart"
Actual results:
search-engines are reactivated in that menu from that screenshot...
Expected results:
Changing the browser-language should definitely not mess with the user's search-engine customization.
Only appears to reset the entire search-engine customization if user did not tick any single search engine:
If user only leaves "Google" entry in that list (removes all others), and ticks that one blue, this bug appears to not occur.
This only affects the one-click enable/disable, removing the engine in the UI works correctly.
Marking this as depending on bug 1650874 where we're working towards a rewrite of the search preferences UI, that may remove the separate option.
| Comment hidden (off-topic) |
Is this the same as or related to bug 1628405?
It is very loosely related, it is a different preference stored in a different place.
It has been this way for a long time - the preference that stores this is a comma-separated list of values (browser.search.hiddenOneOffs).
We should migrate it into the search settings and have it as a flag on the search engine object. It'd also make it better as then all the data would be stored together.
Bug 1643887 is currently fixing this.
Fixed by bug 1643887
Reproducible on a 2023-06-10 Nightly build on Windows 10.
Verified as fixed on Nightly 116.0a1(build ID: 20230620212415) on Windows 10, macOS 12, Ubuntu 22.
Changing the browser language does not re-check the previously unchecked search engines.
Recommend
About Joyk
Aggregate valuable and interesting links.
Joyk means Joy of geeK