Nimbus integration with Search Service should have protection for invalid values
source link: https://bugzilla.mozilla.org/show_bug.cgi?id=1830041
Go to the source link to view the article. You can view the picture content, updated content and better typesetting reading experience. If the link is broken, please click the button below to view the snapshot at that time.
Details
(Whiteboard: [snt-])
I set up a test Nimbus experiment with incorrect extra parameter values. These caused the code to throw and stop initialisation of the search service.
Due to the level of QA that we have I think it would be unlikely to happen in reality. However, I would still be concerned that something could get changed in newer versions of Firefox, and the impacts not realised for older versions.
I think we should have protections in place so that a broken Nimbus experiment cannot stop initialisation/use of the search service.
We should review all Nimbus points, to make sure that we handle exceptions appropriately, and maybe see if there's a way to report back via Nimbus about the experiment not being applied (maybe unenroll with a flag?)
The incorrect branch value was:
{
"extraParams": {
"google_channel_row" : "bar"
}
]
}
This should have been:
{
"extraParams": [
{
"key": "google_channel_row",
"value": "bar"
}
]
}
This caused this function to throw, which then stopped the search service initialising.
Recommend
About Joyk
Aggregate valuable and interesting links.
Joyk means Joy of geeK