Resolve vars in result from `scrape_region_constraints` by compiler-errors · Pul...
source link: https://github.com/rust-lang/rust/pull/112196
Go to the source link to view the article. You can view the picture content, updated content and better typesetting reading experience. If the link is broken, please click the button below to view the snapshot at that time.
Conversation
Member
Since we perform type_op::Normalize in the local infcx when the new solver is enabled, vars aren't necessarily resolved, which triggers this ICE:
There are more tests that go from ICE -> pass due to this change, but I just added revisions to a few for CI.
r? @lcnr
added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue.
labels
| @@ -1,6 +1,6 @@ | ||
// run-pass |
||
// If `Index` used an associated type for its output, this test would |
Index does use an associated type in the ... 8? years since this test was written 
r=me after a style nit
Comment on lines
63 to 64
Op: super::TypeOp<'tcx, Output = R>, |
||
R: TypeFoldable<TyCtxt<'tcx>>, |
Contributor
can you move that to where bounds instead?
Member
Author
|
moved bounds to where clauses @bors r=lcnr |
Commit added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion.
and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties.
labels
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
None yet
Successfully merging this pull request may close these issues.
None yet
Recommend
About Joyk
Aggregate valuable and interesting links.
Joyk means Joy of geeK