@bors r+

Commit 5e917a6 has been approved by petrochenkov

It is now in the queue for this repository.

Testing commit 5e917a6 with merge 2961177...

Test successful - checks-actions
Approved by: petrochenkov
Pushing 2961177 to master...

Finished benchmarking commit (2961177): comparison URL.

Overall result: regressions - ACTION NEEDED

Next Steps: If you can justify the regressions found in this perf run, please indicate this with @rustbot label: +perf-regression-triaged along with sufficient written justification. If you cannot justify the regressions please open an issue or create a new PR that fixes the regressions, add a comment linking to the newly created issue or PR, and then add the perf-regression-triaged label to this PR.

@rustbot label: +perf-regression
cc @rust-lang/wg-compiler-performance

Instruction count

This is a highly reliable metric that was used to determine the overall result at the top of this comment.

mean	range	count
Regressions (primary)	0.4%	[0.2%, 0.6%]	10
Regressions (secondary)	1.2%	[0.6%, 1.9%]	9
Improvements (primary)	-	-	0
Improvements (secondary)	-	-	0
All (primary)	0.4%	[0.2%, 0.6%]	10

Max RSS (memory usage)

Results

Cycles

Results

Binary size

This benchmark run did not return any relevant results for this metric.

Bootstrap: 649.217s -> 648.751s (-0.07%)

• primary regressions are to serde (check, debug, opt) and also cargo + webrender (both check)
• This PR added some extra work to the compiler to ensure some lazily-filled in tables are constructed correctly.
• Therefore, this seems like extra work that is largely unavoidable.
• marking as triaged.

@rustbot label: +perf-regression-triaged