New lint [`min_ident_chars`] by Centri3 · Pull Request #10916 · rust-lang/rust-c...
source link: https://github.com/rust-lang/rust-clippy/pull/10916
Go to the source link to view the article. You can view the picture content, updated content and better typesetting reading experience. If the link is broken, please click the button below to view the snapshot at that time.
Conversation
Collaborator
|
r? @Jarcho (rustbot has picked a reviewer for you, use r? to override) |
added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties label
Contributor
|
Yes, will take it :) |
Some really really nitpicks. Everything else looks fine, Thanks 
Member
|
You just pushed, while I was doing a review xD It looks like that deleted a comment, let's see if I can find that one again |
Contributor
Author
|
Sorry, had to make sure I ran |
Hey, so far, I've only looked at the tests and config implementation. It looks like you're also still working on the branch. These are some nits I found rn. Let me know when you're ready for the next review :)
Member
No problem! It was not the first time this happened, just the first time that GH deleted a comment. It was a simple one to reconstruct though :D |
Contributor
Author
Feel free to take a look whenever, the implementation is already pretty much done. |
Member
|
I looks like the PR has gotten some conflict, without bors adding a comment. Could you resolve them? |
This version looks quite good to me. I have three tiny nits, and then it should be ready :)
Contributor
|
|
The latest upstream changes (presumably Member
|
Looks good to me, thank you! @bors r=blyxyas,xFrednet |
Commit 
Testing commit Contributor
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
None yet
No milestone
Recommend
About Joyk
Aggregate valuable and interesting links.
Joyk means Joy of geeK