Make GDB Python Pretty Printers loadable after spawning GDB, avoiding required `...
source link: https://github.com/rust-lang/rust/pull/111962
Go to the source link to view the article. You can view the picture content, updated content and better typesetting reading experience. If the link is broken, please click the button below to view the snapshot at that time.
Make GDB Python Pretty Printers loadable after spawning GDB, avoiding required rust-gdb
#111962
Conversation
Contributor
Fixes #111961
Makes the Python pretty printer library source'able from within GDB after spawn, making the wrapper script rust-gdb become not the required approach to use the pretty printer library.
Allows for integration into GUI:s that wrap GDB extremely easy. The previous design complicates this feature.
Collaborator
|
Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @Mark-Simulacrum (or someone else) soon. Please see the contribution instructions for more information. Namely, in order to ensure the minimum review times lag, PR authors and assigned reviewers should ensure that the review label (
|
added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label
|
Just a nitpick: this could use a better title, something that describes what it does (see other PR titles for example). Then the "Fixes ###" part can be put in the PR description body, which will link to it and close the issue when this PR merges. |
changed the title
Fix #111961
Make GDB Python Pretty Printers loadable after spawning GDB, avoiding required rust-gdb
Contributor
Author
Thanks! Fixed that. |
Contributor
|
I understand it outmodes rust-gdb, but it does not break it, correct? "defunct" is a word that can be interpreted both ways. |
Contributor
Author
You are correct. Terribly poor phrasing by me. Will be changed. |
Contributor
|
It might be a phrasing that can invite confusion, but I wouldn't call it "terribly poor" at all! Many of the ways you could put it have that dual meaning, tilting towards one, with more or less squinting required to interpret it as the other meaning based on context. |
Contributor
|
@pnkfelix this would let Pernosco load these features in the embedded gdb too |
|
r=me with commits squashed |
Contributor
Author
I'm not sure I did that right? |
|
@bors r+ rollup The approval doesn't go in the commit, it needs to be done by one of the reviewer team members. But this is fine. |
Commit added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion.
and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties.
labels
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
None yet
Successfully merging this pull request may close these issues.
Recommend
About Joyk
Aggregate valuable and interesting links.
Joyk means Joy of geeK