Reduce BitSet size used in `Borrows` dataflow analysis by vlad20012 · Pull Reque...
source link: https://github.com/rust-lang/rust/pull/111396
Go to the source link to view the article. You can view the picture content, updated content and better typesetting reading experience. If the link is broken, please click the button below to view the snapshot at that time.
Conversation
Member
It looks like it is not needed to multiply the number of borrows by 2. Bits greater than self.borrow_set.len() are never set in this bitset. This should decrease the memory usage by an epsilon.
Collaborator
|
r? @cjgillot (rustbot has picked a reviewer for you, use r? to override) |
added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue.
labels
Contributor
This comment has been minimized.
added the S-waiting-on-perf Status: Waiting on a perf run to be completed. label
Trying commit Contributor
|
|
Try build successful - This comment has been minimized.
Collaborator
|
Finished benchmarking commit (5ea3d7f): comparison URL. Overall result:
|
| mean | range | count | |
|---|---|---|---|
Regressions  (primary) |
- | - | 0 |
| Regressions (secondary) |
0.4% | [0.3%, 0.5%] | 2 |
Improvements  (primary) |
- | - | 0 |
| Improvements (secondary) |
- | - | 0 |
| All (primary) |
- | - | 0 |
Max RSS (memory usage)
Results
Cycles
Results
Binary size
This benchmark run did not return any relevant results for this metric.
Bootstrap: 657.767s -> 658.566s (0.12%)
removed the S-waiting-on-perf Status: Waiting on a perf run to be completed. label
Contributor
|
Thanks! |
Commit Contributor
|
|
The tree is currently added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion.
and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties.
labels
Contributor
|
|
Contributor
|
|
Test failed - added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties.
and removed S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion.
labels
Contributor
|
@bors retry |
added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion.
and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties.
labels
Contributor
|
|
Collaborator
|
Finished benchmarking commit (4a59ba4): comparison URL. Overall result: no relevant changes - no action needed@rustbot label: -perf-regression Instruction countThis benchmark run did not return any relevant results for this metric. Max RSS (memory usage)Results CyclesResults Binary sizeThis benchmark run did not return any relevant results for this metric. Bootstrap: 659.596s -> 659.191s (-0.06%) |
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
No reviews
None yet
Successfully merging this pull request may close these issues.
None yet
Recommend
About Joyk
Aggregate valuable and interesting links.
Joyk means Joy of geeK