Implement builtin # syntax and use it for offset_of!(...) by est31 · Pull Reques...
source link: https://github.com/rust-lang/rust/pull/110694
Go to the source link to view the article. You can view the picture content, updated content and better typesetting reading experience. If the link is broken, please click the button below to view the snapshot at that time.
Implement builtin # syntax and use it for offset_of!(...) #110694
Merged
Conversation
Add builtin #
syntax to the parser, as well as a generic infrastructure to support both item and expression position builtin syntaxes. The PR also uses this infrastructure for the implementation of the offset_of!
macro, added by #106934.
cc #110680 builtin #
tracking issue
cc #106655 offset_of!
tracking issue
Collaborator
(rustbot has picked a reviewer for you, use r? to override) |
added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. T-libs Relevant to the library team, which will review and decide on the PR/issue.
labels
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
added A-testsuite Area: The testsuite used to check the correctness of rustc T-bootstrap Relevant to the bootstrap subteam: Rust's build system (x.py and src/bootstrap)
labels
This comment has been minimized.
This comment has been minimized.
Contributor
Once |
Contributor
Author
@clubby789 personally I'd like that, yes. It is imo better to have such a primitive than |
This comment has been minimized.
Contributor
It might be better to have a |
Oh I was unaware of rust-lang/compiler-team#460 and #89030 . It seems to be a special case just to support Unwinding seems to be implemented weirdly, order depending on whether there is a panic call or not:
prints
anyways we should better discuss this in a separate thread, I want to keep this one dedicated to my PR. Edit: filed #110715 |
Collaborator
Hey! It looks like you've submitted a new PR for the library teams! If this PR contains changes to any Examples of
|
added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author.
and removed S-blocked Status: marked as blocked ❌ on something else such as an RFC or other implementation work.
labels
Contributor
Author
@rustbot ready |
added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties.
and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author.
labels
Contributor
@bors r+ |
added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion.
and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties.
labels
This comment has been hidden.
added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author.
and removed S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion.
labels
Contributor
@bors r+ |
added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion.
and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author.
labels
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
None yet
Successfully merging this pull request may close these issues.
None yet
Recommend
About Joyk
Aggregate valuable and interesting links.
Joyk means Joy of geeK