Fix the `FileEncoder` buffer size. by nnethercote · Pull Request #111088 · rust-...

added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue.

labels

May 2, 2023

Contributor

Author

This was a small (sub-1%) but widespread win for me locally, let's see what happens on CI.

@bors try @rust-timer queue

This comment has been minimized.

added the S-waiting-on-perf Status: Waiting on a perf run to be completed. label

May 2, 2023

Contributor

Trying commit 09b380f with merge e959c1c...

Contributor

Try build successful - checks-actions
Build commit: e959c1c (e959c1c6134125cb2710dad9da572e29dca474ab)

This comment has been minimized.

Collaborator

Finished benchmarking commit (e959c1c): comparison URL.

Overall result: improvements - no action needed

Benchmarking this pull request likely means that it is perf-sensitive, so we're automatically marking it as not fit for rolling up. While you can manually mark this PR as fit for rollup, we strongly recommend not doing so since this PR may lead to changes in compiler perf.

@bors rollup=never
@rustbot label: -S-waiting-on-perf -perf-regression

Instruction count

This is a highly reliable metric that was used to determine the overall result at the top of this comment.

mean	range	count
Regressions (primary)	-	-	0
Regressions (secondary)	-	-	0
Improvements (primary)	-0.2%	[-0.3%, -0.2%]	13
Improvements (secondary)	-0.4%	[-0.7%, -0.2%]	7
All (primary)	-0.2%	[-0.3%, -0.2%]	13

Max RSS (memory usage)

Results

Cycles

Results

Binary size

This benchmark run did not return any relevant results for this metric.

Bootstrap: 655.55s -> 655.596s (0.01%)

removed the S-waiting-on-perf Status: Waiting on a perf run to be completed. label

May 2, 2023

Contributor

Author

@bors r=WaffleLapkin

Contributor

Commit 8556960 has been approved by WaffleLapkin

It is now in the queue for this repository.

added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion.

and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties.

labels

May 3, 2023

Contributor

Testing commit 8556960 with merge 83c5a15...

Contributor

Test failed - checks-actions

added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties.

and removed S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion.

labels

This comment has been minimized.

Member

@bors retry

added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion.

and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties.

labels

Contributor

Merge conflict

This pull request and the master branch diverged in a way that cannot be automatically merged. Please rebase on top of the latest master branch, and let the reviewer approve again.

How do I rebase?Error message

removed the S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. label

added the S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. label

Contributor

The latest upstream changes (presumably #111231) made this pull request unmergeable. Please resolve the merge conflicts.

Contributor

Author

I rebased.

@bors r=WaffleLapkin

Contributor

Commit f2df861 has been approved by WaffleLapkin

It is now in the queue for this repository.

added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion.

and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author.

labels

Contributor

Testing commit f2df861 with merge 8006510ab0f69ee75e9c3f7e8bff3776886dae51...

Contributor

Test successful - checks-actions
Approved by: WaffleLapkin
Pushing 8006510 to master...

added the merged-by-bors This PR was explicitly merged by bors label

merged commit 8006510 into

rust-lang:master

12 checks passed

Collaborator

Finished benchmarking commit (8006510): comparison URL.

Overall result: regressions and improvements - ACTION NEEDED

Next Steps: If you can justify the regressions found in this perf run, please indicate this with @rustbot label: +perf-regression-triaged along with sufficient written justification. If you cannot justify the regressions please open an issue or create a new PR that fixes the regressions, add a comment linking to the newly created issue or PR, and then add the perf-regression-triaged label to this PR.

@rustbot label: +perf-regression
cc @rust-lang/wg-compiler-performance

Instruction count

This is a highly reliable metric that was used to determine the overall result at the top of this comment.

mean	range	count
Regressions (primary)	-	-	0
Regressions (secondary)	2.1%	[2.1%, 2.1%]	1
Improvements (primary)	-0.3%	[-0.5%, -0.3%]	10
Improvements (secondary)	-0.4%	[-0.7%, -0.2%]	12
All (primary)	-0.3%	[-0.5%, -0.3%]	10

added the perf-regression Performance regressions label

Member

This is a win overall, and the one regression looks like a return to steady-state after a noisy improvement in the preceding PR #108273 (comment)

@rustbot label: +perf-regression-triaged

added the perf-regression-triaged The performance regression has been triaged. label