3

Stabilize raw-dylib, link_ordinal, import_name_type and -Cdlltool by dpaoliello...

 1 year ago
source link: https://github.com/rust-lang/rust/pull/109677
Go to the source link to view the article. You can view the picture content, updated content and better typesetting reading experience. If the link is broken, please click the button below to view the snapshot at that time.
neoserver,ios ssh client

Conversation

Contributor

This stabilizes the raw-dylib feature (#58713) for all architectures (i.e., x86 as it is already stable for all other architectures).

Changes:

  • Permit the use of the raw-dylib link kind for x86, the link_ordinal attribute and the import_name_type key for the link attribute.
  • Mark the raw_dylib feature as stable.
  • Stabilized the -Zdlltool argument as -Cdlltool.
  • Note the path to dlltool if invoking it failed (we don't need to do this if dlltool returns an error since it prints its path in the error message).
  • Adds tests for -Cdlltool.
  • Adds tests for being unable to find the dlltool executable, and dlltool failing.
  • Fixes a bug where we were checking the exit code of dlltool to see if it failed, but dlltool always returns 0 (indicating success), so instead we need to check if anything was written to stderr.

NOTE: As previously noted (#104218 (comment)) using dlltool within rustc is temporary, but this is not the first time that Rust has added a temporary tool use and argument: #104218 (comment)

Big thanks to @tbu- for the first version of this PR (#104218)

kennykerr, kamulos, slanterns, est31, michaelwoerister, and mominul reacted with hooray emoji

report

Recommend

About Joyk


Aggregate valuable and interesting links.
Joyk means Joy of geeK