1

Convert services/settings/Utils.jsm to an ES module

 1 year ago
source link: https://bugzilla.mozilla.org/show_bug.cgi?id=1816938
Go to the source link to view the article. You can view the picture content, updated content and better typesetting reading experience. If the link is broken, please click the button below to view the snapshot at that time.
neoserver,ios ssh client
Closed Bug 1816938 Opened 2 months ago Closed 12 days ago

Convert services/settings/Utils.jsm to an ES module

Categories

(Firefox :: Remote Settings Client, task)

Tracking

(bug RESOLVED as FIXED)

RESOLVED FIXED

114 Branch

Tracking Status
firefox114 --- fixed

People

(Reporter: standard8, Assigned: anwar.rhsl)

References

(Blocks 1 open bug)

Details

(Whiteboard: [esmification-timeline])

In bug 1816934 we are converting services/settings modules to ES modules.

For that bug I am skipping services/settings/Utils.jsm because migrating that causes test failures in services/settings/test/unit/test_remote_settings_release_prefs.js

The reason for the failures is that the new system does not support unloading ES modules.

I suspect test_remote_settings_release_prefs.js will need splitting up into separate files, so that the tests can be run correctly.

I got this error;

Time elapsed: 807.309seconds
13:54.65 [INFO] Rewritten 18 file(s).
13:54.65 [INFO] Applying eslint --fix for 18 file(s)...
13:54.65 [INFO] 18 files remaining
C:/mozilla-source/mozilla-unified/services/settings/Attachments.sys.mjs
5:10 error 'XPCOMUtils' is defined but never used. no-unused-vars (eslint)

✖ 1 problem (1 error, 0 warnings, 25 fixed)
15:24.18 [INFO] 2 files remaining
✖ 0 problems (0 errors, 0 warnings, 2 fixed)

when I run ./mach esmify --import . --prefix services/settings/Utils.sys.mjs. This comes right after I converted ./mach esmify --convert services/settings/Utils.jsm

Assignee: nobody → anwar.rhsl
Status: NEW → ASSIGNED
Attachment #9325895 - Attachment description: Bug 1816938 - Format code in services/settings/Attachments.sys.mjs to conform with eslint r?Standard8 → Bug 1816938 - Convert services/settings/Utils.jsm to an ES module
Attachment #9324162 - Attachment description: Bug 1816938 - Convert services/settings/utils.jsm to ES modules. r?Standard8 → Bug 1816938 - Convert services/settings/utils.jsm to ES modules. r?Standard8!
Status: ASSIGNED → RESOLVED
Closed: 12 days ago
Resolution: --- → FIXED
Target Milestone: --- → 114 Branch
You need to log in before you can comment on or make changes to this bug.

About Joyk


Aggregate valuable and interesting links.
Joyk means Joy of geeK