7

add ptr::from_{ref,mut} by RalfJung · Pull Request #104977 · rust-lang/rust · Gi...

 1 year ago
source link: https://github.com/rust-lang/rust/pull/104977
Go to the source link to view the article. You can view the picture content, updated content and better typesetting reading experience. If the link is broken, please click the button below to view the snapshot at that time.
neoserver,ios ssh client

add ptr::from_{ref,mut} #104977

Conversation

Member

@RalfJung RalfJung commented Nov 27, 2022 •

edited

We have methods to avoid almost all as casts around raw pointer handling, except for the initial cast from reference to raw pointer. These new methods close that gap.

(I also moved null_mut next to null to keep the file consistently organized.)

r? libs-api

Tracking issue: #106116

joboet, kamulos, marmeladema, and DianaNites reacted with heart emoji

rustbot

added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-libs Relevant to the library team, which will review and decide on the PR/issue.

labels

Nov 27, 2022

Collaborator

rustbot commented Nov 27, 2022

Hey! It looks like you've submitted a new PR for the library teams!

If this PR contains changes to any rust-lang/rust public library APIs then please comment with @rustbot label +T-libs-api -T-libs to tag it appropriately. If this PR contains changes to any unstable APIs please edit the PR description to add a link to the relevant API Change Proposal or create one if you haven't already. If you're unsure where your change falls no worries, just leave it as is and the reviewer will take a look and make a decision to forward on if necessary.

Examples of T-libs-api changes:

  • Stabilizing library features
  • Introducing insta-stable changes such as new implementations of existing stable traits on existing stable types
  • Introducing new or changing existing unstable library APIs (excluding permanently unstable features / features without a tracking issue)
  • Changing public documentation in ways that create new stability guarantees
  • Changing observable runtime behavior of library APIs

Member

Author

RalfJung commented Dec 21, 2022

@rust-lang/libs-api how do we make progress on this PR? It's just been sitting here for 3 weeks now.

Member

@dtolnay dtolnay left a comment

Seems good to me. Please file a tracking issue.

library/core/src/ptr/mod.rs

Outdated Show resolved

Member

Author

RalfJung commented Dec 24, 2022

@bors r=dtolnay

Contributor

bors commented Dec 24, 2022

pushpin Commit 15f72dd has been approved by dtolnay

It is now in the queue for this repository.

bors

added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion.

and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties.

labels

Dec 24, 2022

Contributor

bors commented Dec 24, 2022

hourglass Testing commit 15f72dd with merge ccbb329...

Contributor

bors commented Dec 24, 2022

broken_heart Test failed - checks-actions

bors

added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties.

and removed S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion.

labels

Dec 24, 2022

Collaborator

rust-log-analyzer commented Dec 24, 2022

A job failed! Check out the build log: (web) (plain)

Click to see the possible cause of the failure (guessed by this bot)

Member

dtolnay commented Dec 24, 2022 

curl: (6) Could not resolve host: ci-mirrors.rust-lang.org

@bors retry

bors

added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion.

and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties.

labels

Dec 24, 2022

Contributor

bors commented Dec 24, 2022

hourglass Testing commit 15f72dd with merge 7e4f466...

Contributor

bors commented Dec 24, 2022

sunny Test successful - checks-actions
Approved by: dtolnay
Pushing 7e4f466 to master...

bors

added the merged-by-bors This PR was explicitly merged by bors label

Dec 24, 2022

bors

merged commit 7e4f466 into

rust-lang:master

Dec 24, 2022

12 checks passed

Collaborator

rust-timer commented Dec 24, 2022

Finished benchmarking commit (7e4f466): comparison URL.

Overall result: white_check_mark improvements - no action needed

@rustbot label: -perf-regression

Instruction count

This is a highly reliable metric that was used to determine the overall result at the top of this comment.

mean range count
Regressions x
(primary)		 - - 0
Regressions x
(secondary)		 - - 0
Improvements white_check_mark
(primary)		 - - 0
Improvements white_check_mark
(secondary)		 -4.0% [-4.0%, -4.0%] 1
All xwhite_check_mark (primary) - - 0

Max RSS (memory usage)

This benchmark run did not return any relevant results for this metric.

Cycles

This benchmark run did not return any relevant results for this metric.

RalfJung

deleted the ptr-from-ref branch

Dec 27, 2022

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

dtolnay

Assignees

dtolnay

Labels
merged-by-bors This PR was explicitly merged by bors S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-libs Relevant to the library team, which will review and decide on the PR/issue.
Projects

None yet

Milestone

1.68.0

Development

Successfully merging this pull request may close these issues.

None yet

7 participants

report

Recommend

About Joyk


Aggregate valuable and interesting links.
Joyk means Joy of geeK