Make LLD build forward-compatible with LLVM 16 by nikic · Pull Request #106000 ·...
source link: https://github.com/rust-lang/rust/pull/106000
Go to the source link to view the article. You can view the picture content, updated content and better typesetting reading experience. If the link is broken, please click the button below to view the snapshot at that time.
Make LLD build forward-compatible with LLVM 16 #106000
Merged
Conversation
Contributor
nikic
commented
Dec 21, 2022
Switch to using the cmake module instead of llvm-config. I believe this also removes the need for llvm-config-wrapper.
Collaborator
rustbot commented Dec 21, 2022
|
(rustbot has picked a reviewer for you, use r? to override) |
added A-bootstrap Area: Rust's build system (x.py and src/bootstrap) S-waiting-on-review Status: Awaiting review from the assignee but also interested parties.
labels
Contributor
Author
nikic commented Dec 21, 2022
|
@bors try I wasn't able to test the docker image due to "setting llvm.thin_lto is incompatible with download-ci-llvm", let's see if it works in CI. |
Contributor
bors commented Dec 21, 2022
Trying commit |
r=me when ready |
Contributor
bors commented Dec 21, 2022
|
|
Try build successful - Contributor
Author
nikic commented Dec 21, 2022
|
@bors r=Mark-Simulacrum |
Contributor
bors commented Dec 21, 2022
Commit added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion.
and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties.
labels
Contributor
Author
nikic commented Dec 21, 2022
|
@bors rollup=iffy |
Contributor
bors commented Dec 21, 2022
Contributor
bors commented Dec 21, 2022
|
|
Test failed - added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties.
and removed S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion.
labels
This comment has been minimized.
Contributor
Author
nikic commented Dec 22, 2022
|
Okay, we can't derive the cmake directory from the llvm-config path, because we always return llvm-config for the build triple, not the target triple (we can't execute the target llvm-config binary). So we need to return both the llvm-config path and the cmake directory. The dist-s390x-linux build now works locally. |
Contributor
bors commented Dec 22, 2022
removed the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label
added the S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. label
Contributor
bors commented Dec 22, 2022
Contributor
bors commented Dec 22, 2022
|
|
Collaborator
rust-timer commented Dec 22, 2022
|
Finished benchmarking commit (e5e4eef): comparison URL. Overall result:
|
| mean | range | count | |
|---|---|---|---|
Regressions  (primary) |
- | - | 0 |
| Regressions (secondary) |
- | - | 0 |
Improvements  (primary) |
- | - | 0 |
| Improvements (secondary) |
-1.2% | [-1.2%, -1.2%] | 1 |
| All (primary) |
- | - | 0 |
Max RSS (memory usage)
Results
Cycles
Results
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
No reviews
None yet
Successfully merging this pull request may close these issues.
None yet
Recommend
About Joyk
Aggregate valuable and interesting links.
Joyk means Joy of geeK