always use `anonymize_bound_vars` by compiler-errors · Pull Request #105717 · ru...
source link: https://github.com/rust-lang/rust/pull/105717
Go to the source link to view the article. You can view the picture content, updated content and better typesetting reading experience. If the link is broken, please click the button below to view the snapshot at that time.
always use anonymize_bound_vars
#105717
Conversation
Unless this is perf-sensitive, it's probably best to always use one anonymize function that does the right thing for all bound vars.
r? types
added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue.
labels
This comment has been minimized.
added the S-waiting-on-perf Status: Waiting on a perf run to be completed. label
Contributor
bors commented Dec 14, 2022
Trying commit Contributor
bors commented Dec 14, 2022
|
|
Try build successful - This comment has been minimized.
Collaborator
rust-timer commented Dec 15, 2022
|
Finished benchmarking commit (237fa66): comparison URL. Overall result: no relevant changes - no action neededBenchmarking this pull request likely means that it is perf-sensitive, so we're automatically marking it as not fit for rolling up. While you can manually mark this PR as fit for rollup, we strongly recommend not doing so since this PR may lead to changes in compiler perf. @bors rollup=never Instruction countThis benchmark run did not return any relevant results for this metric. Max RSS (memory usage)Results CyclesThis benchmark run did not return any relevant results for this metric. |
removed the S-waiting-on-perf Status: Waiting on a perf run to be completed. label
Contributor
jackh726 commented Dec 15, 2022
|
@bors r+ rollup=maybe |
Contributor
bors commented Dec 15, 2022
Commit added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion.
and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties.
labels
Contributor
bors commented Dec 16, 2022
Contributor
bors commented Dec 16, 2022
|
|
Test failed - added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties.
and removed S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion.
labels
Member
Author
compiler-errors commented Dec 16, 2022
|
@bors retry unrelated apple test failure in rustdoc |
added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion.
and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties.
labels
Contributor
bors commented Dec 16, 2022
Contributor
bors commented Dec 16, 2022
|
|
Collaborator
rust-timer commented Dec 16, 2022
|
Finished benchmarking commit (a803f31): comparison URL. Overall result: no relevant changes - no action needed@rustbot label: -perf-regression Instruction countThis benchmark run did not return any relevant results for this metric. Max RSS (memory usage)Results CyclesThis benchmark run did not return any relevant results for this metric. |
Collaborator
rust-log-analyzer commented Dec 16, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
No reviews
None yet
Successfully merging this pull request may close these issues.
None yet
Recommend
About Joyk
Aggregate valuable and interesting links.
Joyk means Joy of geeK