Fix new_return_no_self with recursive bounds by nbdd0121 · Pull Request #10086 ·...
source link: https://github.com/rust-lang/rust-clippy/pull/10086
Go to the source link to view the article. You can view the picture content, updated content and better typesetting reading experience. If the link is broken, please click the button below to view the snapshot at that time.
Fix new_return_no_self with recursive bounds #10086
Merged
Conversation
Contributor
nbdd0121
commented
Dec 15, 2022
Fix #10041
This uses a hash set, as described in #10068 (comment)
changelog: [new_return_no_self]: fix stack overflow when the return type is impl Trait and contains recursive bounds
Collaborator
rustbot commented Dec 15, 2022
|
r? @llogiq (rustbot has picked a reviewer for you, use r? to override) |
added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties label
Member
matthiaskrgr
left a comment
Great, thanks!
I ran patched / unpatched clippy through lintcheck in order to see if there were any other side effects in lint output but couldn't find anything (hoping I didn't use it wrongly somehow, it has been a while... ^^' )
Member
matthiaskrgr commented Dec 16, 2022
|
@bors r+ |
Contributor
bors commented Dec 16, 2022
Commit Contributor
bors commented Dec 16, 2022
Testing commit added the beta-nominated Nominated for backporting to the compiler in the beta channel. label
Member
dswij commented Dec 16, 2022
|
@flip1995 IIRC, we agreed this should be backported in Zulip. I've added the label, but let me know if this is not the case. |
|
Thanks for taking care of this! I'll will do the backport in the next few days. Good thing, I didn't have time to do the sync yesterday, so that gets in earlier |
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
None yet
No milestone
Successfully merging this pull request may close these issues.
Recommend
About Joyk
Aggregate valuable and interesting links.
Joyk means Joy of geeK