Address some `EarlyBinder` nits by compiler-errors · Pull Request #103600 · rust...

r? @TaKO8Ki

(rust-highfive has picked a reviewer for you, use r? to override)

@bors try @rust-timer queue

just making sure the use of subst_iter isn't a perf hit, though it shouldn't be

Awaiting bors try build completion.

@rustbot label: +S-waiting-on-perf

Trying commit 2e95130 with merge 2886d4c...

Test failed - checks-actions

Awaiting bors try build completion.

@rustbot label: +S-waiting-on-perf

Trying commit 6a039ff with merge 324f2b4...

Try build successful - checks-actions
Build commit: 324f2b4 (324f2b41f4efea8f1cf67237e8b7adcec50d86de)

Finished benchmarking commit (324f2b4): comparison URL.

Overall result: regressions - ACTION NEEDED

Benchmarking this pull request likely means that it is perf-sensitive, so we're automatically marking it as not fit for rolling up. While you can manually mark this PR as fit for rollup, we strongly recommend not doing so since this PR may lead to changes in compiler perf.

Next Steps: If you can justify the regressions found in this try perf run, please indicate this with @rustbot label: +perf-regression-triaged along with sufficient written justification. If you cannot justify the regressions please fix the regressions and do another perf run. If the next run shows neutral or positive results, the label will be automatically removed.

@bors rollup=never
@rustbot label: +S-waiting-on-review -S-waiting-on-perf +perf-regression

Instruction count

This is a highly reliable metric that was used to determine the overall result at the top of this comment.

mean1	range	count2
Regressions (primary)	0.4%	[0.3%, 0.6%]	8
Regressions (secondary)	-	-	0
Improvements (primary)	-	-	0
Improvements (secondary)	-	-	0
All (primary)	0.4%	[0.3%, 0.6%]	8

Max RSS (memory usage)

This benchmark run did not return any relevant results for this metric.

Cycles

Results

Footnotes

1. the arithmetic mean of the percent change

2. number of relevant changes

Try build successful - checks-actions
Build commit: 79ea737 (79ea73719b947e63649331d19af6f15f22f74780)

Finished benchmarking commit (79ea737): comparison URL.

Overall result: regressions - no action needed

Benchmarking this pull request likely means that it is perf-sensitive, so we're automatically marking it as not fit for rolling up. While you can manually mark this PR as fit for rollup, we strongly recommend not doing so since this PR may lead to changes in compiler perf.

@bors rollup=never
@rustbot label: +S-waiting-on-review -S-waiting-on-perf -perf-regression

Instruction count

This is a highly reliable metric that was used to determine the overall result at the top of this comment.

mean	range	count
Regressions (primary)	0.6%	[0.5%, 0.7%]	2
Regressions (secondary)	-	-	0
Improvements (primary)	-	-	0
Improvements (secondary)	-	-	0
All (primary)	0.6%	[0.5%, 0.7%]	2

Max RSS (memory usage)

This benchmark run did not return any relevant results for this metric.

Cycles

Results

The latest upstream changes (presumably #104555) made this pull request unmergeable. Please resolve the merge conflicts.

Seems like @TaKO8Ki is busy.

r? types

The latest upstream changes (presumably #104905) made this pull request unmergeable. Please resolve the merge conflicts.

Commit f705d64 has been approved by spastorino

It is now in the queue for this repository.

Testing commit f705d64 with merge 935dc07...

Test successful - checks-actions
Approved by: spastorino
Pushing 935dc07 to master...

Finished benchmarking commit (935dc07): comparison URL.

Overall result: regressions - no action needed

@rustbot label: -perf-regression

Instruction count

This is a highly reliable metric that was used to determine the overall result at the top of this comment.

mean	range	count
Regressions (primary)	0.6%	[0.6%, 0.7%]	2
Regressions (secondary)	0.3%	[0.3%, 0.3%]	2
Improvements (primary)	-	-	0
Improvements (secondary)	-	-	0
All (primary)	0.6%	[0.6%, 0.7%]	2

Max RSS (memory usage)

Results

Cycles

This benchmark run did not return any relevant results for this metric.