4

Update browser_tabCloseSpace to use overflowTabs() from BrowserTestUtils

 1 year ago
source link: https://bugzilla.mozilla.org/show_bug.cgi?id=1791438
Go to the source link to view the article. You can view the picture content, updated content and better typesetting reading experience. If the link is broken, please click the button below to view the snapshot at that time.
neoserver,ios ssh client

Details

(Keywords: good-first-bug, Whiteboard: [lang=js])

Currently browser_tabCloseSpacer uses overflowTabs as defined in its own file. With the introduction of the shared-head.js file from Bug 1778450, this test should be changed to use the shared-head implementation instead. Trying to use shared-head.js resulted in having to fight the linter, so I moved the helper function into BrowserTestUtils instead. We should use the shared function from BrowserTestUtils.

Summary: Update browser_tabCloseSpace to use overflowTabs() from shared-head.js → Update browser_tabCloseSpace to use overflowTabs() from BrowserTestUtils

To help Mozilla out with this bug, here's the steps:

  1. Comment here on the bug that you want to volunteer to help.
    This will tell others that you're working on the next steps.
  2. Download and build the Firefox source code
    • If you have any problems, please ask on Element/Matrix in the #introduction channel. They're there to help you get started.
    • You can also read the Developer Guide, which has answers to most development questions.
  3. Start working on this bug.
    • As noted in Comment #0, you'll need to update the test to use BrowserTestUtils.overflowTabs() instead of the test's current implementation.
    • If you have any problems with this bug, please comment on this bug and set the needinfo flag for me. Also, you can find me and my teammates on the #fx-desktop-dev channel on Element/Matrix most hours of most days.
  4. Build your change with mach build and test your change with mach test browser/base/content/test/tabs/browser_tabCloseSpacer.js --headless. Also check your changes for adherence to our style guidelines by using mach lint.
  5. Submit the patch (including an automated test, if applicable) for review. Mark me as a reviewer so I'll get an email to come look at your code.
  6. After a series of reviews and changes to your patch, I'll mark it for checkin or push it to autoland.

report

Recommend

About Joyk


Aggregate valuable and interesting links.
Joyk means Joy of geeK