rustc_metadata: Encode even less doc comments by petrochenkov · Pull Request #10...
source link: https://github.com/rust-lang/rust/pull/103496
Go to the source link to view the article. You can view the picture content, updated content and better typesetting reading experience. If the link is broken, please click the button below to view the snapshot at that time.
rustc_metadata: Encode even less doc comments #103496
Conversation
Contributor
petrochenkov
commented
Oct 24, 2022
The fact that def_id is in the tcx.privacy_access_levels(()) table is not very meaningful, especially after #102026, is_exported (or is_reachable in the worst case) is what you need.
Follow up to #98450.
r? @GuillaumeGomez @lqd
added the T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. label
added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label
Member
lqd commented Oct 24, 2022
|
r=me if a perf run comes back clean The reachability query however, was too much of a pessimization for incremental runs, when it was tried on the previous PR. |
Contributor
Author
petrochenkov commented Oct 24, 2022
Collaborator
rust-timer commented Oct 24, 2022
added the S-waiting-on-perf Status: Waiting on a perf run to be completed. label
Contributor
bors commented Oct 24, 2022
Trying commit removed the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label
Contributor
bors commented Oct 24, 2022
|
|
Try build successful -
Collaborator
rust-timer commented Oct 24, 2022
Collaborator
rust-timer commented Oct 25, 2022
|
Finished benchmarking commit (925fac1): comparison URL. Overall result:
|
| mean1 | range | count2 | |
|---|---|---|---|
Regressions  (primary) |
- | - | 0 |
| Regressions (secondary) |
0.1% | [0.1%, 0.1%] | 1 |
Improvements  (primary) |
- | - | 0 |
| Improvements (secondary) |
-0.2% | [-0.2%, -0.2%] | 1 |
| All (primary) |
- | - | 0 |
Max RSS (memory usage)
Results
Cycles
This benchmark run did not return any relevant results for this metric.
Footnotes
-
the arithmetic mean of the percent change
-
number of relevant changes
added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties.
and removed S-waiting-on-perf Status: Waiting on a perf run to be completed.
labels
Contributor
bors commented Oct 25, 2022
Commit added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion.
and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties.
labels
|
Awesome, thanks a bunch @petrochenkov. What I was particularly interested in the previous work was the impact on libstd/libcore (with the eventual goal of removing more of the unused/unexpected metadata), and on
Most of libcore's doc comments are surely exported anyways (stdarch's intel intrinsics), but that's another nice improvement on libstd. Getting the rest of the way to the expected >= 15% on libstd, and >= 10% on libcore will require finding a way to have tool-specific metadata either out of band, computed on demand via |
added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author.
and removed S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion.
labels
Contributor
Author
petrochenkov commented Oct 29, 2022
Contributor
bors commented Oct 29, 2022
added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion.
and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author.
labels
Contributor
bors commented Oct 31, 2022
Contributor
bors commented Oct 31, 2022
|
|
Test timed out
added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties.
and removed S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion.
labels
Member
lqd commented Oct 31, 2022
added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion.
and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties.
labels
Contributor
bors commented Nov 1, 2022
Contributor
bors commented Nov 1, 2022
Test failed - added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties.
and removed S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion.
labels
Collaborator
rust-log-analyzer commented Nov 1, 2022
Contributor
cjgillot commented Nov 1, 2022
added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion.
and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties.
labels
Contributor
bors commented Nov 1, 2022
Contributor
bors commented Nov 1, 2022
Collaborator
rust-timer commented Nov 1, 2022
|
Finished benchmarking commit (4c736a2): comparison URL. Overall result:
|
| mean | range | count | |
|---|---|---|---|
| Regressions (primary) |
- | - | 0 |
| Regressions (secondary) |
1.7% | [1.7%, 1.7%] | 1 |
| Improvements (primary) |
- | - | 0 |
| Improvements (secondary) |
- | - | 0 |
| All (primary) |
- | - | 0 |
Max RSS (memory usage)
Results
Cycles
Results
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
No reviews
merged-by-bors This PR was explicitly merged by bors S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue.
None yet
Successfully merging this pull request may close these issues.
None yet
</div
Recommend
About Joyk
Aggregate valuable and interesting links.
Joyk means Joy of geeK