3

Missing Create New Login > Cancel button when there are no other logins

 2 years ago
source link: https://bugzilla.mozilla.org/show_bug.cgi?id=1734897
Go to the source link to view the article. You can view the picture content, updated content and better typesetting reading experience. If the link is broken, please click the button below to view the snapshot at that time.
neoserver,ios ssh client
Closed Bug 1734897 Opened 11 months ago Closed 14 days ago

Missing Create New Login > Cancel button when there are no other logins

Categories

(Firefox :: about:logins, defect, P3)

Tracking

(bug RESOLVED as FIXED)

RESOLVED FIXED

106 Branch

Tracking Status
firefox106 --- fixed

People

(Reporter: serg, Assigned: renatoalencar.73, Mentored)

Details

(Keywords: good-first-bug, Whiteboard: [lang=js] [good first bug])

Mentor: sgalich
Severity: -- → S3
Keywords: good-first-bug
Priority: -- → P3
Whiteboard: [lang=javascript] [good first bug]

Hello! I'm an Outreachy applicant and I'd love to work on this bug. May I be assigned, please?

Flags: needinfo?(sgalich)

Clearing assignee to allow others to participate.

Assignee: alaa.elghamry7 → nobody
Flags: needinfo?(sgalich)

:vidutomar19 ask a question when you needinfo? someone

Flags: needinfo?(sgalich)

Hey, what should be the behaviour/action after clicking the CANCEL button? I was thinking of reloading the page as it should be easy to implement.

Thanks & Happy New Year! :)
Kaustubh Dapurkar.

Flags: needinfo?(sgalich)

(In reply to kaustubhdapurkar from comment #5)

Hey, what should be the behaviour/action after clicking the CANCEL button? I was thinking of reloading the page as it should be easy to implement.

I suspect the button doesn't remove new entry from the screen and that's why it was hidden.
Reloading the page is not perfect, but can be accepted.

Flags: needinfo?(sgalich)

Hi, I have made a few changes to fix this bug but I am not very confident about the changes, can someone review the changes even before they are committed? Also open to any suggestions or other approaches to achieve the same result.

Thanks,
Kaustubh Dapurkar.

(In reply to kaustubhdapurkar from comment #7)

Hi, I have made a few changes to fix this bug but I am not very confident about the changes, can someone review the changes even before they are committed? Also open to any suggestions or other approaches to achieve the same result.

Thanks,
Kaustubh Dapurkar.

Sure, just attach your patch to this bug so we can review it.

Assignee: nobody → eghbalniakian
Status: NEW → ASSIGNED

Should I find a different reviewer the patch? Just trying to make sure this doesn't fall under the radar.

Flags: needinfo?(sgalich)

Kian, sorry for the delay, I'll try to get to it soon.

Flags: needinfo?(sgalich)

This good-first-bug hasn't had any activity for 2 months, it is automatically unassigned.
For more information, please visit auto_nag documentation.

Assignee: eghbalniakian → nobody
Status: ASSIGNED → NEW
Whiteboard: [lang=javascript] [good first bug] → [lang=js] [good first bug]
Assignee: nobody → renatoalencar.73
Status: NEW → ASSIGNED
Attachment #9283947 - Attachment description: WIP: Bug 1734897 - Fix about:logins Cancel button behavior → Bug 1734897 - Fix about:logins Cancel button behavior
Attachment #9283947 - Attachment description: Bug 1734897 - Fix about:logins Cancel button behavior → Bug 1734897 - Fix about:logins Cancel button behavior r=sgalich
Comment hidden (off-topic)

Sorry, there was a problem with the detection of inactive users. I'm reverting the change.

Assignee: nobody → renatoalencar.73
Status: NEW → ASSIGNED
Status: ASSIGNED → RESOLVED
Closed: 14 days ago
Resolution: --- → FIXED
Target Milestone: --- → 106 Branch
You need to log in before you can comment on or make changes to this bug.

About Joyk


Aggregate valuable and interesting links.
Joyk means Joy of geeK