4

fix: Parse TypePathFn with preceding `::` by ChayimFriedman2 · Pull Request #131...

 2 years ago
source link: https://github.com/rust-lang/rust-analyzer/pull/13160
Go to the source link to view the article. You can view the picture content, updated content and better typesetting reading experience. If the link is broken, please click the button below to view the snapshot at that time.
neoserver,ios ssh client

Conversation

Contributor

@ChayimFriedman2 ChayimFriedman2 commented 8 days ago •

edited

e.g. impl Fn::() -> ().

Fixes #13157. This was the problem, not that the path was not at the end.

I could unify the parsing of :: of TypePathFn with that of generic arg list, but some code relies on the :: of generic arg list to be inside it.

All reactions

ChayimFriedman2

changed the title Parse TypePathFn with preceding ::

fix: Parse TypePathFn with preceding ::

8 days ago

Collaborator

bors commented 7 days ago

pushpin Commit d786a40 has been approved by jonas-schievink

It is now in the queue for this repository.

Collaborator

bors commented 7 days ago

hourglass Testing commit d786a40 with merge 93c52e4...

Collaborator

bors commented 7 days ago

sunny Test successful - checks-actions
Approved by: jonas-schievink
Pushing 93c52e4 to master...

bors

merged commit 93c52e4 into

rust-lang:master

7 days ago

9 checks passed

ChayimFriedman2

deleted the parse-parenthesized-type-path-with-coloncolon branch

7 days ago

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels
None yet
Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

report

Recommend

About Joyk


Aggregate valuable and interesting links.
Joyk means Joy of geeK