Fix the emission order of `trait_duplication_in_bounds` by Jarcho · Pull Request...
source link: https://github.com/rust-lang/rust-clippy/pull/9397
Go to the source link to view the article. You can view the picture content, updated content and better typesetting reading experience. If the link is broken, please click the button below to view the snapshot at that time.
Fix the emission order of trait_duplication_in_bounds
#9397
Conversation
Makes the lint emit in source order rather than whatever order the hash map happens to be in. This is currently blocking the sync into rustc.
changelog: None
Collaborator
rust-highfive commented 10 days ago
|
r? @flip1995 (rust-highfive has picked a reviewer for you, use r? to override) |
added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties label
added the I-sync-blocker Issue: Prevents a change to be synced to rust-lang/rust label
Member
dswij
left a comment
Change itself looks good to me. How does this issue cause the sync to fail?
| |
||
LL | fn bad_foo<T: Clone + Default, Z: Copy>(arg0: T, arg1: Z) |
||
| ^^^^^^^ |
||
| ^^^^^ |
Both this and the next warning were both emitted with the order depending on the order of a hash map. I guess there was a change recently that caused the order be reversed.
Member
dswij commented 8 days ago
|
Thanks for the fix! @bors r+ |
Contributor
bors commented 8 days ago
Commit Contributor
bors commented 8 days ago
Testing commit Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
None yet
No milestone
Successfully merging this pull request may close these issues.
None yet
Recommend
About Joyk
Aggregate valuable and interesting links.
Joyk means Joy of geeK