I'm having trouble implementing the removal of use statements. With the latest code I get very weird indels generated by code that I don't know where they are -- I failed to setup lldb (breakpoints never hit), and backtrace library is unstable so I can't use it either.

Rust debugging is too difficult for me. I'm requesting help!

/cc @Veykril

Still fails. The stack traces look like

   3: text_edit::assert_disjoint_or_equal
   4: text_edit::TextEditBuilder::indel
   5: text_edit::TextEditBuilder::delete
   6: syntax::algo::TreeDiff::into_text_edit
   7: ide_db::source_change::SourceChangeBuilder::commit
   8: ide_db::source_change::SourceChangeBuilder::finish
   9: ide_assists::assist_context::Assists::add_impl
  10: ide_assists::assist_context::Assists::add
  11: ide_assists::handlers::inline_type_alias::inline_type_alias_uses

I'm unsure why is that happening

I believe the problem you are running into is that you are split_refs_and_uses + remove_path_if_in_use_stmt does removal via mutable syntax nodes, this creates a diff of the tree that then gets applied as text edits, this diff in this case is very disruptive and overlaps with your manual replace calls causing the panic. In general mixing these two APIs (manual replace, delete etc calls on builder with text ranges and using mutable syntax nodes) does not work out well.

@Veykril is it possible to use ted::replace to replace a tree node with an unparsed text? (which is the return value of to_text here)

@Veykril I'm done! :)

ping @Veykril

@bors r+

Commit 364d9c4 has been approved by Veykril

It is now in the queue for this repository.

Testing commit 364d9c4 with merge a1c2653...

Test successful - checks-actions
Approved by: Veykril
Pushing a1c2653 to master...