3

fix: Lower float literals with underscores by ChayimFriedman2 · Pull Request #13...

2 years ago

source link: https://github.com/rust-lang/rust-analyzer/pull/13161
Go to the source link to view the article. You can view the picture content, updated content and better typesetting reading experience. If the link is broken, please click the button below to view the snapshot at that time.

neoserver,ios ssh client

Conversation

Contributor

ChayimFriedman2 commented 8 days ago

Fixes #13155 (the problem was the PI is defined with _f64 suffix). PI is still truncated, though, because f64 cannot represent the value with full precision.

All reactions

ChayimFriedman2

changed the title ~~Lower float literals with underscores~~

fix: Lower float literals with underscores

Collaborator

bors commented 7 days ago

Commit 2eec4ed has been approved by jonas-schievink

It is now in the queue for this repository.

Collaborator

bors commented 7 days ago

Testing commit 2eec4ed with merge f23114c...

Collaborator

bors commented 7 days ago

Test successful - checks-actions
Approved by: jonas-schievink
Pushing f23114c to master...

merged commit f23114c into

rust-lang:master

9 checks passed

ChayimFriedman2

deleted the pi-is-zero branch

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Tooltip shows PI = 0.0

3 participants

Recommend

About Joyk

Aggregate valuable and interesting links.
Joyk means Joy of geeK