rustdoc: use a more compact encoding for implementors/trait.*.js by notriddle ·...

Some changes occurred in HTML/CSS/JS.

cc @GuillaumeGomez, @Folyd, @jsha

r? @jsha

(rust-highfive has picked a reviewer for you, use r? to override)

Looks good to me but I'm curious about the perf impact so let's check.

@bors try @rust-timer queue

Awaiting bors try build completion.

@rustbot label: +S-waiting-on-perf

Trying commit 513cf86 with merge 0c2c82b...

Try build successful - checks-actions
Build commit: 0c2c82b (0c2c82bf492f1dcb836c5bb4c4c3226aeaee389a)

Finished benchmarking commit (0c2c82b): comparison url.

Instruction count

• Primary benchmarks: relevant regressions found
• Secondary benchmarks: relevant regression found

mean1	max	count2
Regressions (primary)	0.6%	0.7%	6
Regressions (secondary)	0.6%	0.6%	1
Improvements (primary)	N/A	N/A	0
Improvements (secondary)	N/A	N/A	0
All (primary)	0.6%	0.7%	6

Max RSS (memory usage)

Results

Cycles

Results

If you disagree with this performance assessment, please file an issue in rust-lang/rustc-perf.

Benchmarking this pull request likely means that it is perf-sensitive, so we're automatically marking it as not fit for rolling up. While you can manually mark this PR as fit for rollup, we strongly recommend not doing so since this PR may lead to changes in compiler perf.

Next Steps: If you can justify the regressions found in this try perf run, please indicate this with @rustbot label: +perf-regression-triaged along with sufficient written justification. If you cannot justify the regressions please fix the regressions and do another perf run. If the next run shows neutral or positive results, the label will be automatically removed.

@bors rollup=never
@rustbot label: +S-waiting-on-review -S-waiting-on-perf +perf-regression

Footnotes

1. the arithmetic mean of the percent change

2. number of relevant changes

The perf impact seems real, probably because of copying Strings around more than necessary. Let's see if using display_fn to write directly to the buffer helps.

@bors try @rust-timer queue

Awaiting bors try build completion.

@rustbot label: +S-waiting-on-perf

Trying commit dddc2fd with merge 10f0d31...

Try build successful - checks-actions
Build commit: 10f0d31 (10f0d312ef4ea28b6ac22029ff3b9317f55830db)

Finished benchmarking commit (10f0d31): comparison url.

Instruction count

• Primary benchmarks: relevant regressions found
• Secondary benchmarks: relevant regressions found

mean1	max	count2
Regressions (primary)	0.6%	1.1%	9
Regressions (secondary)	0.5%	0.8%	2
Improvements (primary)	N/A	N/A	0
Improvements (secondary)	N/A	N/A	0
All (primary)	0.6%	1.1%	9

Max RSS (memory usage)

Results

Cycles

Results

If you disagree with this performance assessment, please file an issue in rust-lang/rustc-perf.

Benchmarking this pull request likely means that it is perf-sensitive, so we're automatically marking it as not fit for rolling up. While you can manually mark this PR as fit for rollup, we strongly recommend not doing so since this PR may lead to changes in compiler perf.

Next Steps: If you can justify the regressions found in this try perf run, please indicate this with @rustbot label: +perf-regression-triaged along with sufficient written justification. If you cannot justify the regressions please fix the regressions and do another perf run. If the next run shows neutral or positive results, the label will be automatically removed.

@bors rollup=never
@rustbot label: +S-waiting-on-review -S-waiting-on-perf +perf-regression

Footnotes

1. the arithmetic mean of the percent change

2. number of relevant changes

Last attempt. If it's not all the string copying, it's probably that serde_json is faster at escaping strings than my naive function was. To try this, I can use serde to implement the same format I was using, except that it uses double-quoted strings, so all the double-quotes in the HTML snippets get backslash escaped. An unfortunate loss, but not a huge deal. Getting rid of the unused data in those files still makes this a huge win.

@bors try @rust-timer queue

Awaiting bors try build completion.

@rustbot label: +S-waiting-on-perf

Trying commit fc31fce with merge 99be0b6...

Try build successful - checks-actions
Build commit: 99be0b6 (99be0b6d211c5348e69332d895ff73bbcee3d9f1)

Finished benchmarking commit (99be0b6): comparison url.

Instruction count

This benchmark run did not return any relevant results for this metric.

Max RSS (memory usage)

Results

Cycles

Results

If you disagree with this performance assessment, please file an issue in rust-lang/rustc-perf.

Benchmarking this pull request likely means that it is perf-sensitive, so we're automatically marking it as not fit for rolling up. While you can manually mark this PR as fit for rollup, we strongly recommend not doing so since this PR may lead to changes in compiler perf.

@bors rollup=never
@rustbot label: +S-waiting-on-review -S-waiting-on-perf -perf-regression

Footnotes

1. the arithmetic mean of the percent change

2. number of relevant changes

Congrats for the perf fix, this is really awesome!

@bors r+

Commit fc31fce has been approved by GuillaumeGomez

It is now in the queue for this repository.

Testing commit fc31fce with merge 34a6cae...

Test successful - checks-actions
Approved by: GuillaumeGomez
Pushing 34a6cae to master...

Finished benchmarking commit (34a6cae): comparison url.

Instruction count

• Primary benchmarks: no relevant changes found
• Secondary benchmarks: relevant improvement found

mean1	max	count2
Regressions (primary)	N/A	N/A	0
Regressions (secondary)	N/A	N/A	0
Improvements (primary)	N/A	N/A	0
Improvements (secondary)	-1.5%	-1.5%	1
All (primary)	N/A	N/A	0

Max RSS (memory usage)

Results

Cycles

Results

If you disagree with this performance assessment, please file an issue in rust-lang/rustc-perf.

@rustbot label: -perf-regression

Footnotes

1. the arithmetic mean of the percent change

2. number of relevant changes