9

Improve Passing Booleans in PHP

 2 years ago
source link: https://freek.dev/2227-improve-passing-booleans-in-php
Go to the source link to view the article. You can view the picture content, updated content and better typesetting reading experience. If the link is broken, please click the button below to view the snapshot at that time.
neoserver,ios ssh client

Oh Dear is the all-in-one monitoring tool for your entire website. We monitor uptime, SSL certificates, broken links, scheduled tasks and more. You'll get a notifications for us when something's wrong. All that paired with a developer friendly API and kick-ass documentation. O, and you'll also be able to create a public status page under a minute. Start monitoring using our free trial now.

Improve Passing Booleans in PHP

Original – Apr 7th 2022 by Freek Van der Herten – 1 minute read

Passing booleans to a method can be code smell, as it is not clear what a boolean does by reading the calling code.

$this->getPrice(true);

A common way to improve on this is by assigning the boolean to a variable with a descriptive name.

$this->getPrice($includingTaxes = true);

Instead of using a temporary variable, you could also use PHP 8's named arguments.

$this->getPrice(includingTaxes: true);

A an even better way to solve this would be to introduce methods with a descriptive name.

class Invoice
{
    public function getPriceIncludingTax(): int
    {
        // …
    }
    
    public function getPriceExcludingTax(): int
    {
        // …
    }
}

// …


$invoice->getPriceIncludingTax();

In general, don't avoid using longer names when they clarify your code. Quality code is not about writing the least amount of words and letters, it's about writing code that can be understood and maintained for years to come.

If you want to read more tips like this one, consider picking up our course on Writing Readable PHP.

Stay up to date with all things Laravel, PHP, and JavaScript.

Follow me on Twitter. I regularly tweet out programming tips, and what I myself have learned in ongoing projects.

Every two weeks I send out a newsletter containing lots of interesting stuff for the modern PHP developer.

Expect quick tips & tricks, interesting tutorials, opinions and packages. Because I work with Laravel every day there is an emphasis on that framework.

Rest assured that I will only use your email address to send you the newsletter and will not use it for any other purposes.

Comments #


Recommend

About Joyk


Aggregate valuable and interesting links.
Joyk means Joy of geeK