Stabilize cfg_target_has_atomic by Amanieu · Pull Request #93824 · rust-lang/rus...
source link: https://github.com/rust-lang/rust/pull/93824
Go to the source link to view the article. You can view the picture content, updated content and better typesetting reading experience. If the link is broken, please click the button below to view the snapshot at that time.
Conversation
r? @davidtwco
(rust-highfive has picked a reviewer for you, use r? to override)
This comment has been hidden.
Commit 49d4823 has been approved by davidtwco
@@ -26,12 +26,10 @@ const GATED_CFGS: &[GatedCfg] = &[
// (name in cfg, feature, function to check if the feature is enabled)
(sym::target_abi, sym::cfg_target_abi, cfg_fn!(cfg_target_abi)),
(sym::target_thread_local, sym::cfg_target_thread_local, cfg_fn!(cfg_target_thread_local)),
(sym::target_has_atomic, sym::cfg_target_has_atomic, cfg_fn!(cfg_target_has_atomic)),
(sym::target_has_atomic_load_store, sym::cfg_target_has_atomic, cfg_fn!(cfg_target_has_atomic)),
Is it intentional that we're stabilizing load_store as well? My recollection of T-lang discussion was that we were intending to limit to just target_has_atomic on the first pass.
I wasn't present in the lang meeting and assumed target_has_atomic_load_store would be stabilized as well since I haven't seen any comments saying otherwise.
OK -- I'm not sure either. I guess this is another point in favor of clear FCPs on long-lived tracking issues with little in the description. Let's not r- this to avoid canceling the rollup as well, and I can make sure that @rust-lang/lang puts this on its agenda on Tuesday next week to discuss whether to stabilize has_atomic_load_store as well.
Over at #32976, @joshtriplett wrote:
We'd like to confirm that we'll have documentation (in the Rust documentation for cfg) of exactly what this checks.
Do we, indeed, have documentation for this? Is there a stabilization report? I'm realizing I have no idea what is being stabilized here and why that subset was chosen.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
None yet
Successfully merging this pull request may close these issues.
None yet
Recommend
About Joyk
Aggregate valuable and interesting links.
Joyk means Joy of geeK