5

Support parsing of asm! args by calebcartwright · Pull Request #5156 · rust-lang...

 2 years ago
source link: https://github.com/rust-lang/rustfmt/pull/5156
Go to the source link to view the article. You can view the picture content, updated content and better typesetting reading experience. If the link is broken, please click the button below to view the snapshot at that time.
neoserver,ios ssh client

Copy link

Member

Author

calebcartwright commented 19 days ago

fyi @ytmimi since this should unblock you. few things to note:

  • all the AsmArgs fields are still private, which means we can't do much with them just yet. I think the operands and templates would suffice, but since we can't really know for sure what all we'll need till we start I opted to leave it as-is
    • i'll send you some notes offline around how you can locally adjust the visibility on the various fields to start working, and once we have a good feel for which ones we'll need we can make the update back in the compiler
  • when checking the call to determine if it's an asm one, be sure to account for calls using a fully qualified path (e.g. core::arch::asm!(...) which I suspect we can handle by looking at the last path segment

About Joyk


Aggregate valuable and interesting links.
Joyk means Joy of geeK