6

[vcpkg_configure_make] MacOS assume target arch is host arch by ekilmer · Pull R...

 2 years ago
source link: https://github.com/microsoft/vcpkg/pull/18632
Go to the source link to view the article. You can view the picture content, updated content and better typesetting reading experience. If the link is broken, please click the button below to view the snapshot at that time.
neoserver,ios ssh client

Copy link

Contributor

ekilmer commented on Jun 24, 2021 •

edited

Describe the pull request

  • What does your PR fix?

    After forgetting to set(VCPKG_OSX_ARCHITECTURES <arch>) in a custom triplet file, I noticed that some configure scripts weren't working. This PR fixes this edge case by reasonably defaulting to the host architecture as the target architecture for macOS builds.

I did a quick search for VCPKG_OSX_ARCHITECTURES and only really found this spot where it is used, but I can see how it would be easy to miss something like this for other build systems in the future, and maybe I'm missing another spot even now.

On the other hand, if VCPKG_OSX_ARCHITECTURES is a required variable with value, then vcpkg should either default to something reasonable earlier in the process as opposed to within each build system script (this PR), or the user should receive an error indicating a value is required for this variable. If you point me to the correct file(s), I can make these changes, but I'm unsure where that is right now. Thank you!

  • Which triplets are supported/not supported? Have you updated the CI baseline?

    Affects osx triplets

  • Does your PR follow the maintainer guide?

  • If you have added/updated a port: Have you run ./vcpkg x-add-version --all and committed the result?


report

Recommend

About Joyk


Aggregate valuable and interesting links.
Joyk means Joy of geeK