5

Add suggestion to missing backticks error by Serial-ATA · Pull Request #7904 · r...

 2 years ago
source link: https://github.com/rust-lang/rust-clippy/pull/7904
Go to the source link to view the article. You can view the picture content, updated content and better typesetting reading experience. If the link is broken, please click the button below to view the snapshot at that time.
neoserver,ios ssh client

Copy link

Member

@xFrednet xFrednet left a comment

Alright, I found two more smaller things where it would be great if you could address them. Then I would merge it. Thank you for the quick changes upside_down_face

tests/ui/doc/doc.stderr

Outdated Show resolved

tests/ui/doc/missing_ticks.rs

Outdated Show resolved

@@ -0,0 +1,9 @@

/// Ok: <http://www.unicode.org/reports/tr9/#Reordering_Resolved_Levels>

Is there a reason why you extracted these two tests?

Copy link

Contributor

Author

@Serial-ATA Serial-ATA 19 days ago

Those two tests fail with rustfix because they have a suggestion that isn't machine applicable, and it's compiled with -Dwarnings.

config.target_rustcflags = Some(format!( "--emit=metadata -Dwarnings -Zui-testing -L dependency={}{}{}",

That explains why some lint test files are split up into a fixable and not fixable test file. Today I learned. Would you mind renaming the doc.rs file to doc-fixable.rs? You can also do that in an additional commit ^^ then everything is really ready upside_down_face


About Joyk


Aggregate valuable and interesting links.
Joyk means Joy of geeK