Add a menu "Move PiP Toggle to Left(Right)" in context menu for the Pi...
source link: https://bugzilla.mozilla.org/show_bug.cgi?id=1680885
Go to the source link to view the article. You can view the picture content, updated content and better typesetting reading experience. If the link is broken, please click the button below to view the snapshot at that time.
Add a menu "Move PiP Toggle to Left(Right)" in context menu for the PiP toggle button
Categories
(Toolkit :: Video/Audio Controls, enhancement)
Tracking
(bug has been fixed and VERIFIED which is tracked for Firefox 95)
95 Branch
People
(Reporter: alice0775, Assigned: rhopkinsdev)
References
(Blocks 1 open bug, Regressed 1 open bug)
Details
(Keywords: nightly-community)
"Hide Picture-in-Picture Toggle" is provided.
I think it would be more convenient if there was "Move PiP Toggle to Left(Right)" menu.
Steps to reproduce:
- Open a Video
- Right click on the PiP toggle button
Expected Results:
The context menu is
"Hide Picture-in-Picture Toggle"
"Move PiP Toggle to Left(Right)"
Pushed by [email protected]: https://hg.mozilla.org/integration/autoland/rev/c97b17652863 Add menu item in Picture-in-Picture toggle context menu to move the toggle to the opposite side of the video. r=mtigley,fluent-reviewers,flod
Micah, is that something we should mention in our release notes? Thanks
(In reply to Pascal Chevrel:pascalc from comment #4)
Micah, is that something we should mention in our release notes? Thanks
Yes! This would be a good addition to our release notes.
[Tracking Requested - why for this release]:
This change adds a new menu item to the Picture-in-Picture toggle button's context menu: "Move Picture-in-Picture Toggle to Left/Right Side". By default, the toggle button is positioned at the right side of a video element but this menu item will allow users to move it to the left side, and vice versa. This was added to allow direct user configuration of the button's positioning.
Release Note Request (optional, but appreciated)
This change adds a new menu item to the Picture-in-Picture toggle button's context menu: "Move Picture-in-Picture Toggle to Left/Right Side". By default, the toggle button is positioned at the right side of a video element but this menu item will allow users to move it to the left side, and vice versa. This was added to allow direct user configuration of the button's positioning.
Doesn't affect Firefox for Android.
Added to Firefox 95 beta release notes with this wording:
The Picture-in-Picture toggle button can now be moved to the opposite side of the video from the new context menu option Move Picture-in-Picture Toggle to Left (Right) Side.
QA verified this implementation (including some exploratory testing) as part of the Beta 95 regression testing 1/3 round, platforms covered: Windows 10, Windows 7, macOS 11.0 and Ubuntu 20.
A spotcheck was performed on Nightly 96 as well, platforms covered: Windows 10, macOS 11.0 ARM , Ubuntu 21.
Our testing revealed no new issue.
Recommend
About Joyk
Aggregate valuable and interesting links.
Joyk means Joy of geeK