Don't inline OnceCell initialization closures by the8472 · Pull Request #89031 ·...

Copy link

Contributor

rust-highfive commented 24 days ago

r? @Mark-Simulacrum

(rust-highfive has picked a reviewer for you, use r? to override)

the8472 commented 24 days ago

rust-timer commented 24 days ago

Awaiting bors try build completion.

@rustbot label: +S-waiting-on-perf

bors commented 24 days ago

Trying commit ca2d2fa with merge 0c1a901...

bors commented 24 days ago

Try build successful - checks-actions
Build commit: 0c1a901 (0c1a9015e49c2d639b1c9832219d5328e7568d8d)

rust-timer commented 24 days ago

rust-timer commented 23 days ago

Finished benchmarking commit (0c1a901): comparison url.

Summary: This change led to small relevant improvements in compiler performance.

• Small improvement in instruction counts (up to -0.6% on incr-unchanged builds of issue-46449)

If you disagree with this performance assessment, please file an issue in rust-lang/rustc-perf.

Benchmarking this pull request likely means that it is perf-sensitive, so we're automatically marking it as not fit for rolling up. While you can manually mark this PR as fit for rollup, we strongly recommend not doing so since this PR led to changes in compiler perf.

@bors rollup=never
@rustbot label: +S-waiting-on-review -S-waiting-on-perf -perf-regression

I guess it's possible this will end up hurting performance if the initialization is actually hot (e.g., the OnceCell is guarding something that must be done only once but usually only happens once). But that seems like a relatively unlikely edge case, and the wins here are nice -- though notably primarily limited to -doc builds, which suggests that this is mostly an improvement for those compiling without PGO (like rustdoc is today). That's most Rust users though.

@bors r+

bors commented 23 days ago

Commit ca2d2fa has been approved by Mark-Simulacrum

bors commented 21 days ago

Testing commit ca2d2fa with merge 7a3d1a5...

bors commented 21 days ago

Test successful - checks-actions
Approved by: Mark-Simulacrum
Pushing 7a3d1a5 to master...

rust-timer commented 21 days ago

Finished benchmarking commit (7a3d1a5): comparison url.

Summary: This change led to moderate relevant mixed results in compiler performance.

• Moderate improvement in instruction counts (up to -0.9% on full builds of helloworld)
• Moderate regression in instruction counts (up to 0.7% on incr-patched: println builds of deep-vector)

If you disagree with this performance assessment, please file an issue in rust-lang/rustc-perf.

Next Steps: If you can justify the regressions found in this perf run, please indicate this with @rustbot label: +perf-regression-triaged along with sufficient written justification. If you cannot justify the regressions please open an issue or create a new PR that fixes the regressions, add a comment linking to the newly created issue or PR, and then add the perf-regression-triaged label to this PR.

@rustbot label: +perf-regression

pnkfelix commented 19 days ago

Weekly perf triage. This was categorized as a regression under our old performance evaluation scheme.

However, we have revised our evaluation metrics, especially how we determine significance, and with that in place, the regression to deep-vector incr-patched: println builds are no longer considered significant in this case.

@rustbot label: +perf-regression-triaged