5
Change diff highlighting background for dark mode by jharrilim · Pull Request #4...
source link: https://github.com/rails/rails/pull/42989
Go to the source link to view the article. You can view the picture content, updated content and better typesetting reading experience. If the link is broken, please click the button below to view the snapshot at that time.
Summary
The background highlight in dark mode diffs aren't easy to look at right now due to the contrast between the text and background color. This change proposes to unset the background color of the text so that it goes up against the black background. Alternatively, a more gentle highlight doesn't look to bad.
Other Information
Current
background-color: unset
.gd { background-color: #211 } .gi { background-color: #121 }
Recommend
About Joyk
Aggregate valuable and interesting links.
Joyk means Joy of geeK