![](/style/images/good.png)
![](/style/images/bad.png)
Fix the request side panel empty params text
source link: https://bugzilla.mozilla.org/show_bug.cgi?id=1711845
Go to the source link to view the article. You can view the picture content, updated content and better typesetting reading experience. If the link is broken, please click the button below to view the snapshot at that time.
Fix the request side panel empty params text
Categories
(DevTools :: Console, enhancement, P3)
Tracking
(firefox91 fixed)
91 Branch
People
(Reporter: contact, Assigned: jha.ashray12)
References
(Blocks 1 open bug)
Details
(Keywords: good-first-bug)
User Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:88.0) Gecko/20100101 Firefox/88.0
Steps to reproduce:
When an ajax request (XHR) is sending in "GET" mode the "params" is not visible and still empty. But all is working well in "POST" mode.
The problem is present on "console" and "network" menu.
Bonjour! Thanks for the report.
Is this happening on all requests? It looks like the request in the screenshot is taking a while (> 7s), and I wonder if that could cause the issue here.
Did you expand the request before it's completed? If you have control over releves_data.php
, what happens if you return an empty array (so it doesn't take as long).
Also, would you be able to test again Firefox Nightly? I think we fixed a similar issue not long ago, so it would be nice to check if it's different.
Merci :)
Yes it's happend on all requests, on the screenshot it was normal for the 7s delay, it's a big data file to return. But the problem is also present on google or other website for exemple, but only for GET xhr.
Few weeks ago the problem didn't exist, but in the past I remember that antoher problem appends on xhr GET request too (the params was not separated and was in one line, but now the new bug is different because params is totaly empty) I am not sure but I think it's happened recently on the latests versions.
Thanks
The GET parameters are now displayed in the Headers (En-tête) panel, below the URL
The Request panel only shows the Form data now
The wording of the panel title + the "empty" text can be confusing, let's see if we can do better
Ah great thanks for the screenshot, I had not seen that the params of "get" was here, but now I understand why in "Request" you have only the form params, and in headers the url params, it seems logical.
Merci :)
Bomsy: find proper title and next steps
Based on the discussions, lets update the text which shows when there are request parameters which is currently "No parameters for this request"
to something more specific, maybe "No payload body for this request"
or just "No payload for this request"
.
Honza,
Did you have some suggestions on the text content as well?
"No payload for this request" sound great
Hello, I would like to work on this issue, some guide from your side will be great :)
HI jha,
Have you setup Firefox for development? If not see https://firefox-source-docs.mozilla.org/devtools/index.html#contributing
To reproduce,
- Go to any google.com
- Open devtools and the netmonitor
- Select the first request and click the request side panel
- The request panel empty text is
No parameters for this request
On Fixing the the test, you just need to change the text to match the new text suggested in Comment 7
to run the test do ./mach test browser_net_complex-params.js
Hello @bomsy, kindly review my patch .
Thanks! :)
The patch looks good! good work! Let's wait for try to finish before we land.
Thanks
Recommend
About Joyk
Aggregate valuable and interesting links.
Joyk means Joy of geeK