3

Reorder case statements in "AboutLoginsChromeToContent" switch in abou...

 3 years ago
source link: https://bugzilla.mozilla.org/show_bug.cgi?id=1688896
Go to the source link to view the article. You can view the picture content, updated content and better typesetting reading experience. If the link is broken, please click the button below to view the snapshot at that time.

Details

(Whiteboard: [lang=js][good first bug])

To make this switch flow logically, we need to re-arrange some case statements in aboutLogins.js. These cases are ordered alphabetically.

Severity: -- → N/A
Priority: -- → P4
Whiteboard: [lang=js][good first bug]

Hi ! Can I work on this issue ?

Flags: needinfo?(tgiles)

Jyoti, thanks for volunteering! Feel free to go ahead and work on this!

To help Mozilla out with this bug, here's the steps:

  1. Download and build the Firefox source code
    • If you have any problems, please ask on
      Element/Matrix
      in the #introduction channel. They're there to help you get started.
    • You can also read the
      Developer Guide,
      which has answers to most development questions.
  2. Start working on this bug.
    • Please re-arrange the case statements in aboutLogins.js so that they are ordered alphabetically.
    • If you have any problems with this bug,
      please comment on this bug and set the needinfo flag for me.
      Also, you can find me and my teammates on the #lockwise-desktop channel on
      Element/Matrix
      most hours of most days.
  3. Build your change with mach build and test your change with
    mach test browser/components/aboutlogins/.
    Also check your changes for adherence to our style guidelines by using mach lint
  4. Submit the patch (including an automated test, if applicable) for review.
    Mark me as a reviewer so I'll get an email to come look at your code.
  5. After a series of reviews and changes to your patch,
    I'll mark it for checkin or push it to autoland.
    Your code will soon be shipping to Firefox users worldwide!
  6. ...now you get to think about what kind of bug you'd like to work on next.
    Let me know what you're interested in and I can help you find your next contribution.

About Joyk


Aggregate valuable and interesting links.
Joyk means Joy of geeK