6

Github Tweak trait not `use`d suggestion by estebank · Pull Request #84499 · rus...

 3 years ago
source link: https://github.com/rust-lang/rust/pull/84499
Go to the source link to view the article. You can view the picture content, updated content and better typesetting reading experience. If the link is broken, please click the button below to view the snapshot at that time.
neoserver,ios ssh client

Copy link

Contributor

jackh726 left a comment

This looks reasonable except for the additional diagnostic. r=me with that removed or if you really think that extra label is helpful :)

err.span_label(

pick.item.ident.span,

&format!("the method is available for `{}` here", rcvr_ty),

);

Comment on lines

+1019 to +1022

jackh726 25 days ago

Contributor

I'm really not sure how useful this is...imo the module/use statement is enough.

estebank 25 days ago

Author

Contributor

I think it helps a little bit when in concert with the suggestion, because the suggestion text doesn't explain why importing that trait would be enough.


About Joyk


Aggregate valuable and interesting links.
Joyk means Joy of geeK