8

Github Fix dotnet pack on net5.0 by thinkbeforecoding · Pull Request #4007 · fsp...

 3 years ago
source link: https://github.com/fsprojects/Paket/pull/4007
Go to the source link to view the article. You can view the picture content, updated content and better typesetting reading experience. If the link is broken, please click the button below to view the snapshot at that time.
neoserver,ios ssh client

Conversation

Copy link

Contributor

thinkbeforecoding commented 3 days ago

This is a fix for dotnet paket pack on net5.0
This should solve #3980 and #3994
The short version string for net5.0 is no 50 but 5.0

The rest of the tests seems to work and this is conform to net5.0 (inconsistent) versioning so it seems legit.

Copy link

Contributor

Author

thinkbeforecoding commented 3 days ago

On the way I removed the set MSBUILD from build.cmd that was pointing to a packages/ path that has been removed in a previous commit but has not been fixed for windows

Copy link

Contributor

Author

thinkbeforecoding commented 2 days ago

The appveyor built failed but it seems unrelated to the actual change

forki

merged commit 4988936 into fsprojects:master 2 days ago

1 of 2 checks passed

Copy link

Member

forki commented 2 days ago

thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

No reviews

Assignees

No one assigned

Labels
None yet
Projects

None yet

Milestone

No milestone

Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants

report

Recommend

About Joyk


Aggregate valuable and interesting links.
Joyk means Joy of geeK