Github Change branching in `iter.skip()` by JulianKnodt · Pull Request #80715 ·...

JulianKnodt commented 25 days ago •

New impl benchmarks:

test iter::bench_cycle_skip_take_ref_sum                        ... bench:   3,511,135 ns/iter (+/- 72,608)
test iter::bench_cycle_skip_take_sum                            ... bench:   3,002,478 ns/iter (+/- 102,090)
test iter::bench_cycle_take_skip_ref_sum                        ... bench:   2,709,985 ns/iter (+/- 60,129)
test iter::bench_cycle_take_skip_sum                            ... bench:   2,342,344 ns/iter (+/- 20,248)
test iter::bench_skip_chain_ref_sum                             ... bench:   4,170,133 ns/iter (+/- 162,633)
test iter::bench_skip_chain_sum                                 ... bench:     759,909 ns/iter (+/- 10,462)
test iter::bench_skip_cycle_skip_zip_add_ref_sum                ... bench:   6,170,983 ns/iter (+/- 47,253)
test iter::bench_skip_cycle_skip_zip_add_sum                    ... bench:   4,242,784 ns/iter (+/- 7,138)
test iter::bench_skip_ref_sum                                   ... bench:   1,668,988 ns/iter (+/- 3,920)
test iter::bench_skip_sum                                       ... bench:     379,766 ns/iter (+/- 10,567)
test iter::bench_skip_then_zip                                  ... bench:         142 ns/iter (+/- 0)
test iter::bench_zip_then_skip                                  ... bench:          98 ns/iter (+/- 0)

New impl w/o ? after nth:

test iter::bench_cycle_skip_take_ref_sum                        ... bench:   3,553,941 ns/iter (+/- 163,030)
test iter::bench_cycle_skip_take_sum                            ... bench:   3,122,332 ns/iter (+/- 39,716)
test iter::bench_cycle_take_skip_ref_sum                        ... bench:   2,738,281 ns/iter (+/- 7,677)
test iter::bench_cycle_take_skip_sum                            ... bench:   2,286,484 ns/iter (+/- 71,319)
test iter::bench_skip_chain_ref_sum                             ... bench:   4,078,560 ns/iter (+/- 42,944)
test iter::bench_skip_chain_sum                                 ... bench:     759,928 ns/iter (+/- 3,369)
test iter::bench_skip_cycle_skip_zip_add_ref_sum                ... bench:   6,090,941 ns/iter (+/- 15,114)
test iter::bench_skip_cycle_skip_zip_add_sum                    ... bench:   4,389,274 ns/iter (+/- 13,194)
test iter::bench_skip_ref_sum                                   ... bench:   1,662,695 ns/iter (+/- 6,873)
test iter::bench_skip_sum                                       ... bench:     379,615 ns/iter (+/- 3,894)
test iter::bench_skip_then_zip                                  ... bench:         143 ns/iter (+/- 0)
test iter::bench_zip_then_skip                                  ... bench:         100 ns/iter (+/- 0)

Old impl benchmark:

test iter::bench_cycle_skip_take_ref_sum                        ... bench:   3,496,163 ns/iter (+/- 271,462)
test iter::bench_cycle_skip_take_sum                            ... bench:   3,017,929 ns/iter (+/- 22,208)
test iter::bench_cycle_take_skip_ref_sum                        ... bench:   2,725,668 ns/iter (+/- 15,420)
test iter::bench_cycle_take_skip_sum                            ... bench:   2,341,441 ns/iter (+/- 20,861)
test iter::bench_skip_chain_ref_sum                             ... bench:   4,264,607 ns/iter (+/- 113,524)
test iter::bench_skip_chain_sum                                 ... bench:     759,955 ns/iter (+/- 7,522)
test iter::bench_skip_cycle_skip_zip_add_ref_sum                ... bench:   7,042,158 ns/iter (+/- 499,251)
test iter::bench_skip_cycle_skip_zip_add_sum                    ... bench:   4,947,926 ns/iter (+/- 230,305)
test iter::bench_skip_ref_sum                                   ... bench:   1,836,314 ns/iter (+/- 64,051)
test iter::bench_skip_sum                                       ... bench:     379,617 ns/iter (+/- 297)
test iter::bench_skip_then_zip                                  ... bench:         126 ns/iter (+/- 1)
test iter::bench_zip_then_skip                                  ... bench:         100 ns/iter (+/- 0)