stabilize const_int_pow by tspiteri · Pull Request #76829 · rust-lang/rust · Git...

Contributor

rust-highfive commented on Sep 17

r? @Mark-Simulacrum

(rust_highfive has picked a reviewer for you, use r? to override)

tspiteri commented on Sep 17

This PR stabilized const for the following public methods:

• {i*,u*}::checked_pow
• {i*,u*}::saturating_pow
• {i*,u*}::wrapping_pow
• {i*,u*}::overflowing_pow
• {i*,u*}::pow
• u*::next_power_of_two
• u*::checked_next_power_of_two
• u*::wrapping_next_power_of_two (the method itself is still unstable)

Mark-Simulacrum commented on Sep 19

r? @KodrAus to kick off libs FCP here, diff in PR looks good from an impl perspective

bors commented on Sep 20

The latest upstream changes (presumably #76327) made this pull request unmergeable. Please resolve the merge conflicts.

Note that reviewers usually do not review pull requests until merge conflicts are resolved! Once you resolve the conflicts, you should change the labels applied by bors to indicate that your PR is ready for review. Post this as a comment to change the labels:

@rustbot modify labels: +S-waiting-on-review -S-waiting-on-author

bors commented on Sep 23

The latest upstream changes (presumably #76850) made this pull request unmergeable. Please resolve the merge conflicts.

Note that reviewers usually do not review pull requests until merge conflicts are resolved! Once you resolve the conflicts, you should change the labels applied by bors to indicate that your PR is ready for review. Post this as a comment to change the labels:

@rustbot modify labels: +S-waiting-on-review -S-waiting-on-author

tspiteri commented on Oct 3

I've just force-pushed an update with the since field set to "1.49.0" since this cannot possibly complete FCP before 1.48.0 goes into beta.

KodrAus commented on Oct 5

@rfcbot fcp merge

See: #76829 (comment)

This stabilizes a few more const methods on integers.

cc @rust-lang/wg-const-eval

rfcbot commented on Oct 5 •

Team member @KodrAus has proposed to merge this. The next step is review by the rest of the tagged team members:

No concerns currently listed.

Once a majority of reviewers approve (and at most 2 approvals are outstanding), this will enter its final comment period. If you spot a major issue that hasn't been raised at any point in this process, please speak up!

See this document for info about what commands tagged team members can give me.

rfcbot commented on Nov 13

This is now entering its final comment period, as per the review above.

bors commented on Nov 19

The latest upstream changes (presumably #79167) made this pull request unmergeable. Please resolve the merge conflicts.

Note that reviewers usually do not review pull requests until merge conflicts are resolved! Once you resolve the conflicts, you should change the labels applied by bors to indicate that your PR is ready for review. Post this as a comment to change the labels:

@rustbot modify labels: +S-waiting-on-review -S-waiting-on-author

tspiteri commented 27 days ago

Done.

oli-obk commented 27 days ago

@bors r+

bors commented 27 days ago

Commit a6bcf7a has been approved by oli-obk

bors commented 27 days ago

Testing commit a6bcf7a with merge b1801ff...

bors commented 27 days ago

Test failed - checks-actions

oli-obk commented 27 days ago

@bors retry gzip failures in CI